Infer CL author and reviewer list from local state if the issue has not previously been uploaded.

git_cl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 """A git-command for integrating reviews on Rietveld."""
 
 from distutils.version import LooseVersion
@@ skipping 1676 matching lines @@
     args = [base_branch, 'HEAD']
 
   # Apply watchlists on upload.
   change = cl.GetChange(base_branch, None)
   watchlist = watchlists.Watchlists(change.RepositoryRoot())
   files = [f.LocalPath() for f in change.AffectedFiles()]
   if not options.bypass_watchlists:
     cl.SetWatchers(watchlist.GetWatchersForPaths(files))
 
   if not options.bypass_hooks:
+    if options.reviewers:
+      # Set the reviewer list now so that presubmit checks can access it.
+      setattr(change, 'R', ','.join(options.reviewers))

[Ilya Sherman, 2014/03/14 01:45:33]

There's probably a better way to do this.  Thoughts?

[agable, 2014/03/14 15:11:03]

presubmit_support.py has a Change class which is capable of handling "tag
lines", i.e. lines at the end of a change description of the form R=, TBR=, and
BUG=. It saves the values of these tags into Change.tags['<tagname>']. It's also
capable of modifying those tags -- it automatically writes the R= line on upload
based on the --reviewers flags, and it automatically cleans up the R= and TBR=
lines based on who actually LGTM'd the change. You should reuse the logic there
to handle this.

[Ilya Sherman, 2014/03/18 01:18:35]

The Change class doesn't actually ever update the R= line.  That's handled by
the ChangeDescription class in this file.  I've added a method to the Change
class to update and re-parse the description.  This changes the class from an
immutable one to a mutable one.  Is that ok?

[agable, 2014/03/18 17:56:52]

You're right, I was working from faulty memory :) Your change is the right thing
to do.

     hook_results = cl.RunHook(committing=False,
                               may_prompt=not options.force,
                               verbose=options.verbose,
                               change=change)
     if not hook_results.should_continue():
       return 1
     if not options.reviewers and hook_results.reviewers:
       options.reviewers = hook_results.reviewers.split(',')
 
   if cl.GetIssue():
@@ skipping 824 matching lines @@
         ('AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
           'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
 
 
 if __name__ == '__main__':
   # These affect sys.stdout so do it outside of main() to simplify mocks in
   # unit testing.
   fix_encoding.fix_encoding()
   colorama.init()
   sys.exit(main(sys.argv[1:]))