Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: src/a64/lithium-codegen-a64.cc

Issue 195793016: Remove uses of CanBeNegative() in HMod. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4116 matching lines...) Expand 10 before | Expand all | Expand 10 after
4127 4127
4128 // Theoretically, a variation of the branch-free code for integer division by 4128 // Theoretically, a variation of the branch-free code for integer division by
4129 // a power of 2 (calculating the remainder via an additional multiplication 4129 // a power of 2 (calculating the remainder via an additional multiplication
4130 // (which gets simplified to an 'and') and subtraction) should be faster, and 4130 // (which gets simplified to an 'and') and subtraction) should be faster, and
4131 // this is exactly what GCC and clang emit. Nevertheless, benchmarks seem to 4131 // this is exactly what GCC and clang emit. Nevertheless, benchmarks seem to
4132 // indicate that positive dividends are heavily favored, so the branching 4132 // indicate that positive dividends are heavily favored, so the branching
4133 // version performs better. 4133 // version performs better.
4134 HMod* hmod = instr->hydrogen(); 4134 HMod* hmod = instr->hydrogen();
4135 int32_t mask = divisor < 0 ? -(divisor + 1) : (divisor - 1); 4135 int32_t mask = divisor < 0 ? -(divisor + 1) : (divisor - 1);
4136 Label dividend_is_not_negative, done; 4136 Label dividend_is_not_negative, done;
4137 if (hmod->left()->CanBeNegative()) { 4137 if (hmod->CheckFlag(HValue::kLeftCanBeNegative)) {
4138 __ Cmp(dividend, 0); 4138 __ Cmp(dividend, 0);
4139 __ B(pl, &dividend_is_not_negative); 4139 __ B(pl, &dividend_is_not_negative);
4140 // Note that this is correct even for kMinInt operands. 4140 // Note that this is correct even for kMinInt operands.
4141 __ Neg(dividend, dividend); 4141 __ Neg(dividend, dividend);
4142 __ And(dividend, dividend, Operand(mask)); 4142 __ And(dividend, dividend, Operand(mask));
4143 __ Neg(dividend, dividend); 4143 __ Neg(dividend, dividend);
4144 if (hmod->CheckFlag(HValue::kBailoutOnMinusZero)) { 4144 if (hmod->CheckFlag(HValue::kBailoutOnMinusZero)) {
4145 DeoptimizeIf(eq, instr->environment()); 4145 DeoptimizeIf(eq, instr->environment());
4146 } 4146 }
4147 __ B(&done); 4147 __ B(&done);
(...skipping 1684 matching lines...) Expand 10 before | Expand all | Expand 10 after
5832 __ Bind(&out_of_object); 5832 __ Bind(&out_of_object);
5833 __ Ldr(result, FieldMemOperand(object, JSObject::kPropertiesOffset)); 5833 __ Ldr(result, FieldMemOperand(object, JSObject::kPropertiesOffset));
5834 // Index is equal to negated out of object property index plus 1. 5834 // Index is equal to negated out of object property index plus 1.
5835 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2)); 5835 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2));
5836 __ Ldr(result, FieldMemOperand(result, 5836 __ Ldr(result, FieldMemOperand(result,
5837 FixedArray::kHeaderSize - kPointerSize)); 5837 FixedArray::kHeaderSize - kPointerSize));
5838 __ Bind(&done); 5838 __ Bind(&done);
5839 } 5839 }
5840 5840
5841 } } // namespace v8::internal 5841 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698