Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 195793012: De-virtualize SkCanvas matrix ops. (Closed)

Created:
6 years, 9 months ago by f(malita)
Modified:
6 years, 9 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

De-virtualize SkCanvas matrix ops. This moves the matrix management logic into non-virtual SkCanvas methods, and turns the virtuals into protected notifiers. R=reed@google.com,robertphillips@google.com BUG=skia:2297 Committed: http://code.google.com/p/skia/source/detail?r=13799

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -203 lines) Patch
M experimental/PdfViewer/SkNulCanvas.h View 1 chunk +0 lines, -6 lines 0 comments Download
M include/core/SkCanvas.h View 2 chunks +13 lines, -6 lines 0 comments Download
M include/utils/SkDeferredCanvas.h View 2 chunks +7 lines, -6 lines 0 comments Download
M include/utils/SkDumpCanvas.h View 2 chunks +7 lines, -7 lines 0 comments Download
M include/utils/SkLuaCanvas.h View 2 chunks +7 lines, -7 lines 0 comments Download
M include/utils/SkNWayCanvas.h View 2 chunks +7 lines, -6 lines 0 comments Download
M include/utils/SkProxyCanvas.h View 2 chunks +7 lines, -7 lines 0 comments Download
M src/core/SkBBoxHierarchyRecord.h View 2 chunks +7 lines, -7 lines 0 comments Download
M src/core/SkBBoxHierarchyRecord.cpp View 1 chunk +12 lines, -17 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +44 lines, -7 lines 0 comments Download
M src/core/SkPictureRecord.h View 2 chunks +7 lines, -6 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 7 chunks +12 lines, -12 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 8 chunks +19 lines, -18 lines 0 comments Download
M src/utils/SkCanvasStack.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/utils/SkCanvasStack.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 chunk +12 lines, -17 lines 0 comments Download
M src/utils/SkDumpCanvas.cpp View 1 chunk +12 lines, -12 lines 0 comments Download
M src/utils/SkLuaCanvas.cpp View 1 chunk +12 lines, -12 lines 0 comments Download
M src/utils/SkNWayCanvas.cpp View 1 chunk +12 lines, -12 lines 0 comments Download
M src/utils/SkProxyCanvas.cpp View 1 chunk +17 lines, -11 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 3 chunks +7 lines, -12 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 3 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
f(malita)
Preparing for lazy save, phase 2. Why "did" and not "will"? Overrides in SkBBoxHierarchyRecord are ...
6 years, 9 months ago (2014-03-12 22:23:47 UTC) #1
reed1
<bikeshed>I think I like pre- and post- better than will- and did- </bikeshed> lgtm
6 years, 9 months ago (2014-03-13 12:03:08 UTC) #2
bsalomon
On 2014/03/13 12:03:08, reed1 wrote: > <bikeshed>I think I like pre- and post- better than ...
6 years, 9 months ago (2014-03-13 15:02:03 UTC) #3
reed1
On 2014/03/13 15:02:03, bsalomon wrote: > On 2014/03/13 12:03:08, reed1 wrote: > > <bikeshed>I think ...
6 years, 9 months ago (2014-03-13 15:04:41 UTC) #4
bsalomon
On 2014/03/13 15:04:41, reed1 wrote: > On 2014/03/13 15:02:03, bsalomon wrote: > > On 2014/03/13 ...
6 years, 9 months ago (2014-03-13 15:24:14 UTC) #5
reed1
On 2014/03/13 15:24:14, bsalomon wrote: > On 2014/03/13 15:04:41, reed1 wrote: > > On 2014/03/13 ...
6 years, 9 months ago (2014-03-13 15:52:20 UTC) #6
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 9 months ago (2014-03-13 19:58:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/195793012/1
6 years, 9 months ago (2014-03-13 19:58:31 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-13 20:04:05 UTC) #9
Message was sent while issue was closed.
Change committed as 13799

Powered by Google App Engine
This is Rietveld 408576698