Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: src/core/SkPicturePlayback.h

Issue 195793010: Add a means of extracting active operations from SkPicture (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Add EXPERIMENTAL prefix to the new entry point Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/core/SkPicturePlayback.h
===================================================================
--- src/core/SkPicturePlayback.h (revision 13766)
+++ src/core/SkPicturePlayback.h (working copy)
@@ -85,6 +85,8 @@
virtual ~SkPicturePlayback();
+ const SkTDArray<void*>* getActiveOps(const SkIRect& queryRect);
bsalomon 2014/03/13 17:59:34 The signature seems a little dangerous to me.
robertphillips 2014/03/14 17:59:34 Done. I think I have addressed your concerns here.
+
void draw(SkCanvas& canvas, SkDrawPictureCallback*);
void serialize(SkWStream*, SkPicture::EncodeBitmap) const;
@@ -109,7 +111,7 @@
virtual void postDraw(int opIndex);
#endif
- void preLoadBitmaps(const SkTDArray<void*>& results);
+ void preLoadBitmaps(const SkTDArray<void*>* results);
private:
class TextContainer {
@@ -237,6 +239,11 @@
SkBBoxHierarchy* fBoundingHierarchy;
SkPictureStateTree* fStateTree;
+ // The query rect for which the cached active ops are valid
+ SkIRect fCacheQueryRect;
+ // The operations which are active within 'fCachedQueryRect'
+ SkTDArray<void*>* fCachedActiveOps;
+
SkTypefacePlayback fTFPlayback;
SkFactoryPlayback* fFactoryPlayback;
#ifdef SK_BUILD_FOR_ANDROID

Powered by Google App Engine
This is Rietveld 408576698