Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 195793004: Implement overscroll support for the virtual keyboard. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix work area resize when virtual keyboard is shown. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_impl.cc
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc
index 2b3762f9a3c8318bea87c7e8be08e2da428b8975..45a12bebe56e01609c66949084bc8a8757f9fb10 100644
--- a/content/browser/renderer_host/render_widget_host_impl.cc
+++ b/content/browser/renderer_host/render_widget_host_impl.cc
@@ -601,13 +601,16 @@ void RenderWidgetHostImpl::WasResized() {
is_fullscreen_ = IsFullscreen();
float old_overdraw_bottom_height = overdraw_bottom_height_;
overdraw_bottom_height_ = view_->GetOverdrawBottomHeight();
+ int old_visible_viewport_height = visible_viewport_height_;
+ visible_viewport_height_ = view_->GetVisibleViewportHeight();
bool size_changed = new_size != last_requested_size_;
bool side_payload_changed =
screen_info_out_of_date_ ||
old_physical_backing_size != physical_backing_size_ ||
was_fullscreen != is_fullscreen_ ||
- old_overdraw_bottom_height != overdraw_bottom_height_;
+ old_overdraw_bottom_height != overdraw_bottom_height_ ||
+ old_visible_viewport_height != visible_viewport_height_;
if (!size_changed && !side_payload_changed)
return;
@@ -627,6 +630,7 @@ void RenderWidgetHostImpl::WasResized() {
params.new_size = new_size;
params.physical_backing_size = physical_backing_size_;
params.overdraw_bottom_height = overdraw_bottom_height_;
kevers 2014/04/23 17:09:13 Based on discussions with aelias, it appears that
aelias_OOO_until_Jul13 2014/04/23 19:41:58 Hmm, it's ugly to introduce a new parameter for su
kevers 2014/04/24 02:02:13 Done.
kevers 2014/04/24 18:38:33 Using Size instead of SizeF based on sky's feedbac
+ params.visible_viewport_height = visible_viewport_height_;
params.resizer_rect = GetRootWindowResizerRect();
params.is_fullscreen = is_fullscreen_;
if (!Send(new ViewMsg_Resize(routing_id_, params))) {

Powered by Google App Engine
This is Rietveld 408576698