Implement overscroll support for the virtual keyboard.

content/browser/renderer_host/render_widget_host_view_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
 
 #include "base/auto_reset.h"
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/callback_helpers.h"
@@ skipping 857 matching lines @@
   else
     return bounds;
 }
 
 void RenderWidgetHostViewAura::SetBackground(const SkBitmap& background) {
   RenderWidgetHostViewBase::SetBackground(background);
   host_->SetBackground(background);
   window_->layer()->SetFillsBoundsOpaquely(background.isOpaque());
 }
 
+int RenderWidgetHostViewAura::GetVisibleViewportHeight() const {
+  gfx::Rect window_bounds = window_->GetBoundsInScreen();
+  gfx::Rect intersect = gfx::IntersectRects(window_bounds,
+                                            virtual_keyboard_bounds_);
+  int overlap = intersect.height();
+  if (overlap > 0 && overlap < window_bounds.height())
+    return window_bounds.height() - overlap;
+  return GetViewBounds().height();
+}
+
+void RenderWidgetHostViewAura::SetKeyboardBounds(const gfx::Rect& bounds) {

[sky, 2014/04/23 20:47:08]

Is there a reason you can't set an insets? I'm thinking of an API like:

SetInsets(const gfx::Insets& insets);

I also don't like that the coordinates of this function are screen. That makes
it super easy to get wrong.

[kevers, 2014/04/23 20:57:49]

The reason for explicitly using screen coordinates is that the keyboard is only
displayed on the primary root window.  SetInsets would work well if the clipping
applied across all displays.

[sky, 2014/04/23 21:15:31]

Isn't that an implementation detail? Can't the keyboard figure out the insets
and set it?

[kevers, 2014/04/24 02:02:13]

Done.

+  if (bounds != virtual_keyboard_bounds_) {
+    virtual_keyboard_bounds_ = bounds;
+    host_->WasResized();
+  }
+}
+
 void RenderWidgetHostViewAura::UpdateCursor(const WebCursor& cursor) {
   current_cursor_ = cursor;
   const gfx::Display display = gfx::Screen::GetScreenFor(window_)->
       GetDisplayNearestWindow(window_);
   current_cursor_.SetDisplayInfo(display);
   UpdateCursorIfOverSelf();
 }
 
 void RenderWidgetHostViewAura::SetIsLoading(bool is_loading) {
   is_loading_ = is_loading;
@@ skipping 2282 matching lines @@
     RenderWidgetHost* widget) {
   return new RenderWidgetHostViewAura(widget);
 }
 
 // static
 void RenderWidgetHostViewPort::GetDefaultScreenInfo(WebScreenInfo* results) {
   GetScreenInfoForWindow(results, NULL);
 }
 
 }  // namespace content