Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: build/common.gypi

Issue 195793003: Re-activate the -Wno-deprecated-register flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 28e3389b76fe724be78b51b54f52bc61a5c1b274..ec1429366d766e66a9c88686686fd675921769b3 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -4153,23 +4153,17 @@
# Warns when a const char[] is converted to bool.
'-Wstring-conversion',
+
+ # Clang considers the `register` keyword as deprecated, but
+ # e.g. code generated by flex (used in angle) contains that
+ # keyword. http://crbug.com/255186
+ '-Wno-deprecated-register',
],
'conditions': [
['clang_xcode==0', {
'CC': '$(SOURCE_ROOT)/<(clang_dir)/clang',
'LDPLUSPLUS': '$(SOURCE_ROOT)/<(clang_dir)/clang++',
-
- 'WARNING_CFLAGS': [
- # Clang considers the `register` keyword as deprecated, but
- # e.g. code generated by flex (used in angle) contains that
- # keyword. http://crbug.com/255186
- #
- # Note: clang as shipped with Xcode is older and does not
- # treat the `register` as deprecated and does not define
- # this flag, so don't enable it if "clang_xcode" is "1".
- '-Wno-deprecated-register',
- ],
}],
],
}],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698