tools/gn/command_gyp.cc - Issue 19579005: Move ReadFileToString to the base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/command_gyp.cc

Issue 19579005: Move ReadFileToString to the base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/command_gyp.cc

diff --git a/tools/gn/command_gyp.cc b/tools/gn/command_gyp.cc

index 80b23cbd2057d43ef56008394c3ec46d4d269657..736f7e12754e268c62e1496e01da68fd6b2bc244 100644

--- a/tools/gn/command_gyp.cc

+++ b/tools/gn/command_gyp.cc

@@ -69,7 +69,7 @@ bool SimpleNinjaParse(const std::string& data,

bool FixupBuildNinja(const BuildSettings* build_settings,

const base::FilePath& buildfile) {

std::string contents;

- if (!file_util::ReadFileToString(buildfile, &contents)) {

+ if (!base::ReadFileToString(buildfile, &contents)) {

Err(Location(), "Could not load " + FilePathToUTF8(buildfile))

.PrintToStdout();

return false;