[MD settings] layout of the site settings page

[MD settings] layout of the site settings page

This CL changes the layout of the main site settings section.
It now uses settings-box styles. The order of the sections has also
been changed (per mocks).

BUG=599667, 589630
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b1d46bf66b0983b5e71f5c08b608317c9d7d0f3d
Cr-Commit-Position: refs/heads/master@{#393092}

[dschuyler, 2016-05-07 01:09:12]

Description was changed from

==========
[MD settings] layout of the site settings page

This CL changes the layout of the main site settings section.
It now uses settings-box styles. The order of the sections has also
been changed (per mocks).

BUG=599667, 589630
==========

to

==========
[MD settings] layout of the site settings page

This CL changes the layout of the main site settings section.
It now uses settings-box styles. The order of the sections has also
been changed (per mocks).

BUG=599667, 589630
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-05-07 01:10:44]

Patchset #1 (id:1) has been deleted

[dschuyler, 2016-05-07 01:13:25]

Patchset #1 (id:20001) has been deleted

[dschuyler, 2016-05-07 01:15:59]

dschuyler@chromium.org changed reviewers:
+ finnur@chromium.org

[dschuyler, 2016-05-07 01:18:06]

On 2016/05/07 01:16:00, dschuyler wrote:

There is a screen shot of the new layout at http://imgur.com/ZGeSMsr

[Finnur, 2016-05-08 11:26:40]

In general, this looks fine, except the new order of permissions doesn't look
right. The permissions are ordered by most-sensitive first, and I believe the
mocks (and therefore your screenshot) do not show the correct order.
Specifically, Camera and Microphone permissions are much more sensitive than the
Images, Javascript and Popups permission. Images should probably be last of
those. 

Anyway, you should follow the same order that Site Settings in Chrome for
Android uses, as that's the currently approved order and I haven't heard anyone
wanting to change that.

Also, once you sync you'll unfortunately have some conflicts with a CL of mine
that aligns the icons and text better with the menu, as described in
crbug.com/608131.

[dschuyler, 2016-05-09 17:32:01]

On 2016/05/08 11:26:40, Finnur wrote:
> In general, this looks fine, except the new order of permissions doesn't look
> right. The permissions are ordered by most-sensitive first, and I believe the
> mocks (and therefore your screenshot) do not show the correct order.
> Specifically, Camera and Microphone permissions are much more sensitive than
the
> Images, Javascript and Popups permission. Images should probably be last of
> those. 
> 
> Anyway, you should follow the same order that Site Settings in Chrome for
> Android uses, as that's the currently approved order and I haven't heard
anyone
> wanting to change that.

Cool, that makes sense, but let's get that order specified in our mocks or
design :)
I made a bug here for that here:
https://bugs.chromium.org/p/chromium/issues/detail?id=610358

> 
> Also, once you sync you'll unfortunately have some conflicts with a CL of mine
> that aligns the icons and text better with the menu, as described in
> crbug.com/608131.

[Finnur, 2016-05-09 17:43:22]

Yup. That would be good. Thanks!

[dschuyler, 2016-05-09 23:59:38]

I changed the order of the entries back to what they were.

[Finnur, 2016-05-10 10:45:24]

My only remaining concern is that this regresses crbug.com/608131. 

But if the icons and text line up as in the screenshot in comment 4, then this
is fine.

[dschuyler, 2016-05-10 18:42:26]

On 2016/05/10 10:45:24, Finnur wrote:
> My only remaining concern is that this regresses crbug.com/608131. 
> 
> But if the icons and text line up as in the screenshot in comment 4, then this
> is fine.

I made another patch to line up the items correctly (vertically).
screen shot at imgur.com/LMTV8qX

[Finnur, 2016-05-11 09:48:21]

LGTM

[dschuyler, 2016-05-11 16:50:58]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2016-05-11 16:51:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1957823002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1957823002/80001

[commit-bot: I haz the power, 2016-05-11 17:00:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 17:00:38]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dschuyler, 2016-05-11 22:42:22]

Patchset #4 (id:100001) has been deleted

[dschuyler, 2016-05-11 22:42:29]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2016-05-11 22:42:29]

The patchset sent to the CQ was uploaded after l-g-t-m from finnur@chromium.org
Link to the patchset: https://codereview.chromium.org/1957823002/#ps120001
(title: "merge with master")

[commit-bot: I haz the power, 2016-05-11 22:42:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1957823002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1957823002/120001

[commit-bot: I haz the power, 2016-05-11 22:48:19]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2016-05-11 22:50:42]

Description was changed from

==========
[MD settings] layout of the site settings page

This CL changes the layout of the main site settings section.
It now uses settings-box styles. The order of the sections has also
been changed (per mocks).

BUG=599667, 589630
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] layout of the site settings page

This CL changes the layout of the main site settings section.
It now uses settings-box styles. The order of the sections has also
been changed (per mocks).

BUG=599667, 589630
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b1d46bf66b0983b5e71f5c08b608317c9d7d0f3d
Cr-Commit-Position: refs/heads/master@{#393092}
==========

[commit-bot: I haz the power, 2016-05-11 22:50:43]

Patchset 4 (id:??) landed as
https://crrev.com/b1d46bf66b0983b5e71f5c08b608317c9d7d0f3d
Cr-Commit-Position: refs/heads/master@{#393092}