Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1957753002: Clean up IPAddress::ToString related TODO. (Closed)

Created:
4 years, 7 months ago by martijnc
Modified:
4 years, 7 months ago
Reviewers:
Sergey Ulanov, eroman
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up IPAddress::ToString related TODO. Committed: https://crrev.com/b8db9ba385ae3a2823a5dcc48acaf889c0f650f3 Cr-Commit-Position: refs/heads/master@{#392670}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M net/quic/p2p/quic_p2p_session.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
martijnc
IPAddress::ToString() no longer crashes on invalid or empty addresses and this issue was likely fixed ...
4 years, 7 months ago (2016-05-09 19:25:37 UTC) #2
Sergey Ulanov
lgtm
4 years, 7 months ago (2016-05-09 23:25:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957753002/1
4 years, 7 months ago (2016-05-10 17:44:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/180534)
4 years, 7 months ago (2016-05-10 17:52:32 UTC) #7
martijnc
+eroman as net/* OWNER. Can you take a look? Thanks!
4 years, 7 months ago (2016-05-10 18:06:41 UTC) #9
eroman
lgtm
4 years, 7 months ago (2016-05-10 18:55:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957753002/1
4 years, 7 months ago (2016-05-10 19:04:21 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 19:09:28 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b8db9ba385ae3a2823a5dcc48acaf889c0f650f3 Cr-Commit-Position: refs/heads/master@{#392670}
4 years, 7 months ago (2016-05-10 19:11:14 UTC) #15
tommycli
4 years, 7 months ago (2016-05-11 17:08:42 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1964143005/ by tommycli@chromium.org.

The reason for reverting is: Speculatively reverting because this may have
broken a Dr. Memory bot:

First breaking build:
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%2....

Powered by Google App Engine
This is Rietveld 408576698