Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1957693002: Revert of [css-grid] Fix definite/indefinite size detection for abspos elements (patchset #2 id:200… (Closed)

Created:
4 years, 7 months ago by cbiesinger
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Revert of [css-grid] Fix definite/indefinite size detection for abspos elements (patchset #2 id:20001 of https://codereview.chromium.org/1383003002/ ) Reason for revert: This is breaking how percentages work in Flexbox and Grid compared to regular Blocks. There're some discussion ongoing on the CSS WG to verify the expected behavior, so we're reverting this for now until we've a final resolution. Original issue's description: > [css-grid] Fix definite/indefinite size detection for abspos elements > > We were considering that any abspos element has a definite size, and > that's not true. That's only true if the offset properties in that > dimension (left and right or top and bottom) are non-auto. > Fixed LayoutBox::hasDefiniteLogicalWidth|Height() to check this > properly. > > This has been confirmed by the CSS WG in the following thread: > https://lists.w3.org/Archives/Public/www-style/2015Nov/0074.html > > BUG=538513 > TEST=fast/css-grid-layout/positioned-grid-container-percentage-tracks.html > > Committed: https://crrev.com/b75b9bdaa3ede6fe0230ae822885d6fb38ed514b > Cr-Commit-Position: refs/heads/master@{#386045} TBR=cbiesinger@chromium.org,svillar@igalia.com,mstensho@opera.com BUG=538513, 603854, 604346, 608783 Review-Url: https://codereview.chromium.org/1954683002 Cr-Commit-Position: refs/heads/master@{#391789} (cherry picked from commit 83e80002d146d1493ae16c1cb585cc458e955ee3) Committed: https://chromium.googlesource.com/chromium/src/+/4cac97891d80a3f9789d4c5ae02a40ca4c9d3c21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -107 lines) Patch
D third_party/WebKit/LayoutTests/fast/css-grid-layout/positioned-grid-container-percentage-tracks.html View 1 chunk +0 lines, -103 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
cbiesinger
4 years, 7 months ago (2016-05-06 17:26:45 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4cac97891d80a3f9789d4c5ae02a40ca4c9d3c21.

Powered by Google App Engine
This is Rietveld 408576698