Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: content/browser/BUILD.gn

Issue 1957683002: Address more TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@todo
Patch Set: iOS Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/policy/BUILD.gn ('k') | content/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/BUILD.gn
diff --git a/content/browser/BUILD.gn b/content/browser/BUILD.gn
index ad6af0bef30e6ede1e7675275ea3646bfae22810..62a7d2af1d285fbc6c4b0e74418cc28d75103fa1 100644
--- a/content/browser/BUILD.gn
+++ b/content/browser/BUILD.gn
@@ -123,10 +123,11 @@ source_set("browser") {
".",
"//content")
- # TODO(GYP) these generated files are listed as sources in content_browser.
- # This is a bit suspicious. The GN grit template will make a source set
- # containing the generated code so it should be sufficient to just depend
- # on the grit rule. But maybe some of these will need to be added?
+ # TODO(GYP_GONE) these generated files are listed as sources in
+ # content_browser. This is a bit suspicious. The GN grit template will make
+ # a source set containing the generated code so it should be sufficient to
+ # just depend on the grit rule. But maybe some of these will need to be
+ # added?
#
# Need this annoying rebase_path call to match what happened with the
# sources.
@@ -160,12 +161,6 @@ source_set("browser") {
deps += [ "//printing" ]
}
- # TODO(GYP)
- # [chrome_multiple_dll!=1', {
- # 'dependencies': [
- # '../third_party/WebKit/public/blink.gyp:blink',
- # ],
- # }],
if (!is_mac) {
deps += [ "//sandbox" ]
}
« no previous file with comments | « components/policy/BUILD.gn ('k') | content/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698