Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: components/BUILD.gn

Issue 1957683002: Address more TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@todo
Patch Set: iOS Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/tools/BUILD.gn ('k') | components/crash.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/BUILD.gn
diff --git a/components/BUILD.gn b/components/BUILD.gn
index 5c8387e446d35453d40bba6c38558b76189e18b9..e669b75d6f64eeef7587a3b30442ca1e10ebe521 100644
--- a/components/BUILD.gn
+++ b/components/BUILD.gn
@@ -164,6 +164,7 @@ test("components_unittests") {
"//components/autofill/content/renderer:unit_tests",
"//components/cast_certificate:unit_tests",
"//components/certificate_transparency:unit_tests",
+ "//components/crash/content/app:unit_tests",
"//components/data_reduction_proxy/content/browser:unit_tests",
"//components/data_use_measurement/content:unit_tests",
"//components/devtools_http_handler:unit_tests",
@@ -270,9 +271,6 @@ test("components_unittests") {
]
}
- # TODO(GYP) need this target.
- #'breakpad/app/crash_keys_win_unittest.cc',
-
if (enable_configuration_policy) {
deps += [
"//components/policy/core/browser:unit_tests",
@@ -365,7 +363,7 @@ if (is_android) {
}
# GYP: //components/components_tests.gyp:components_junit_tests
- # TODO(GYP): Delete this target once recipes no longer require it.
+ # TODO(GYP_GONE): Delete this target once recipes no longer require it.
junit_binary("components_junit_tests") {
java_files = [ "//testing/android/junit/DummyTest.java" ]
}
« no previous file with comments | « chrome/tools/BUILD.gn ('k') | components/crash.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698