Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1584)

Unified Diff: components/BUILD.gn

Issue 1957683002: Address more TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@todo
Patch Set: fix Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/BUILD.gn
diff --git a/components/BUILD.gn b/components/BUILD.gn
index 5c8387e446d35453d40bba6c38558b76189e18b9..48d476f72425ba3411ae029aee9808ee57a1f1e3 100644
--- a/components/BUILD.gn
+++ b/components/BUILD.gn
@@ -70,6 +70,7 @@ test("components_unittests") {
"//components/component_updater:unit_tests",
"//components/content_settings/core/browser:unit_tests",
"//components/content_settings/core/common:unit_tests",
+ "//components/crash/content/app:unit_tests",
"//components/crx_file:unit_tests",
"//components/data_reduction_proxy/core/browser:unit_tests",
"//components/data_reduction_proxy/core/common:unit_tests",
@@ -270,9 +271,6 @@ test("components_unittests") {
]
}
- # TODO(GYP) need this target.
- #'breakpad/app/crash_keys_win_unittest.cc',
-
if (enable_configuration_policy) {
deps += [
"//components/policy/core/browser:unit_tests",
@@ -365,7 +363,7 @@ if (is_android) {
}
# GYP: //components/components_tests.gyp:components_junit_tests
- # TODO(GYP): Delete this target once recipes no longer require it.
+ # TODO(GYP_GONE): Delete this target once recipes no longer require it.
junit_binary("components_junit_tests") {
java_files = [ "//testing/android/junit/DummyTest.java" ]
}
« chrome/test/BUILD.gn ('K') | « chrome/tools/BUILD.gn ('k') | components/crash.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698