third_party/WebKit/Source/modules/BUILD.gn - Issue 1957683002: Address more TODO(GYP) in the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/BUILD.gn

Issue 1957683002: Address more TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@todo

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/BUILD.gn

diff --git a/third_party/WebKit/Source/modules/BUILD.gn b/third_party/WebKit/Source/modules/BUILD.gn

index 3a28f6a7250ee009168134e29047bffc2cafff1c..fa34111f4917d799931ac2548f5495f626d07443 100644

--- a/third_party/WebKit/Source/modules/BUILD.gn

+++ b/third_party/WebKit/Source/modules/BUILD.gn

@@ -58,12 +58,6 @@ component("modules") {

if (is_win) {

cflags = [ "/wd4334" ] # Result of 32-bit shift implicitly converted to 64 bits.

- # TODO(GYP)

- # Shard this taret into parts to work around linker limitations.

- # on link time code generation builds.

- #[buildtype=="Official"', {

- # 'msvs_shard': 5,

- #}],

}

if (remove_webcore_debug_symbols) {