Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1566)

Unified Diff: chrome/test/BUILD.gn

Issue 1957683002: Address more TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@todo
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/BUILD.gn
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
index c5ef543c6144f22499969788a89aaf95bc33dbfe..72b4770858fb05158d616b5af872e488ea234ebd 100644
--- a/chrome/test/BUILD.gn
+++ b/chrome/test/BUILD.gn
@@ -244,7 +244,7 @@ source_set("test_support") {
}
}
-# TODO(GYP): Delete this after we've converted everything to GN.
+# TODO(GYP_GONE): Delete this after we've converted everything to GN.
# The _run targets exist only for compatibility w/ GYP.
group("telemetry_gpu_test_run") {
testonly = true
@@ -698,6 +698,17 @@ if (!is_android) {
"data/webui/settings/easy_unlock_browsertest_chromeos.js",
]
}
+ if (is_mac) {
+ sources -= [
+ # TODO(rouslan): This test depends on the custom dictionary UI,
+ # which is disabled on Mac.
+ "../browser/ui/webui/options/edit_dictionary_browsertest.js",
+
+ # TODO(rouslan): This test depends on hunspell and we cannot run it
+ # on Mac, which does use hunspell by default.
+ "../browser/ui/webui/options/language_options_dictionary_download_browsertest.js",
+ ]
+ }
if (!enable_app_list) {
sources -= [ "../browser/ui/webui/app_list/start_page_browsertest.js" ]
}
@@ -715,7 +726,7 @@ if (!is_android) {
defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ]
}
- # TODO(GYP): Delete this after we've converted everything to GN.
+ # TODO(GYP_GONE): Delete this after we've converted everything to GN.
# The _run targets exist only for compatibility w/ GYP.
group("telemetry_perf_unittests_run") {
testonly = true
@@ -738,7 +749,7 @@ if (!is_android) {
]
}
- # TODO(GYP): Delete this after we've converted everything to GN.
+ # TODO(GYP_GONE): Delete this after we've converted everything to GN.
# The _run targets exist only for compatibility w/ GYP.
group("telemetry_unittests_run") {
testonly = true
@@ -795,7 +806,7 @@ if (!is_android) {
]
}
- # TODO(GYP): Delete this after we've converted everything to GN.
+ # TODO(GYP_GONE): Delete this after we've converted everything to GN.
# The _run targets exist only for compatibility w/ GYP.
group("tab_capture_end2end_tests_run") {
testonly = true
@@ -804,7 +815,7 @@ if (!is_android) {
]
}
- # TODO(GYP): Delete this after we've converted everything to GN.
+ # TODO(GYP_GONE): Delete this after we've converted everything to GN.
# The _run targets exist only for compatibility w/ GYP.
group("mash_browser_tests_run") {
testonly = true
@@ -965,11 +976,6 @@ if (!is_android) {
defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ]
- # TODO(GYP) if (is_win) {
- # ['incremental_chrome_dll==1', {
- # 'UseLibraryDependencyInputs': "true",
- # }
-
if (!enable_one_click_signin) {
sources -= [ "../browser/ui/sync/one_click_signin_links_delegate_impl_browsertest.cc" ]
}
@@ -1184,10 +1190,9 @@ if (!is_android) {
# chrome_resources.gyp:{packed_extra_resources,packed_resources},
# and can build this target standalone much faster.
deps += [
- #'app_mode_app_support', TODO(GYP)
"//chrome",
-
- #'../components/components.gyp:breakpad_stubs', TODO(GYP)
+ "//chrome/common:app_mode_app_support",
+ "//components/crash/content/app:breakpad_stubs",
"//third_party/ocmock",
]
sources += [
@@ -1199,16 +1204,6 @@ if (!is_android) {
# Mac, which does not use hunspell by default.
"../browser/spellchecker/spellcheck_service_browsertest.cc",
- # TODO(rouslan): This test depends on the custom dictionary UI,
- # which is disabled on Mac.
- # TODO(GYP): This should be added somewhere first ...
- # "../browser/ui/webui/options/edit_dictionary_browsertest.js",
-
- # TODO(rouslan): This test depends on hunspell and we cannot run it
- # on Mac, which does use hunspell by default.
- # TODO(GYP): This should be added somewhere first ...
- # "../browser/ui/webui/options/language_options_dictionary_download_browsertest.js",
-
# ProcessSingletonMac doesn"t do anything.
"../browser/process_singleton_browsertest.cc",
@@ -1342,7 +1337,7 @@ if (!is_android) {
chrome_tests_gypi_values.chrome_browser_tests_remoting_sources,
".",
"//chrome")
- #deps += [ "//remoting:remoting_webapp" ] TODO(GYP)
+ deps += [ "//remoting/webapp" ]
}
if (use_x11) {
deps += [ "//tools/xdisplaycheck" ]
@@ -1665,10 +1660,6 @@ test("unit_tests") {
]
data_deps = []
- # TODO(GYP) Windows stuff
- # ['incremental_chrome_dll==1', {
- # 'UseLibraryDependencyInputs': "true",
-
if (!is_ios) {
deps += [
"//components/autofill/content/renderer:test_support",
@@ -1685,8 +1676,8 @@ test("unit_tests") {
"//device/usb:mocks",
"//gpu:test_support",
"//media:test_support",
-
- #'../ppapi/ppapi_internal.gyp:ppapi_unittest_shared', TODO(GYP)
+ "//ppapi/proxy:test_support",
+ "//ppapi/shared_impl:test_support",
"//third_party/leveldatabase",
"//third_party/libaddressinput",
"//third_party/libjingle",
@@ -2222,9 +2213,8 @@ if (safe_browsing_mode == 1 && is_mac) {
}
}
-if (is_win || is_mac || is_linux) {
- # TODO(GYP): Figure out which of these work and are needed on other
- # platforms.
+if (!is_android) {
+ # TODO(609855): Make this compile on Android and run on the bots.
test("chrome_app_unittests") {
sources = [
"../app/chrome_watcher_client_unittest_win.cc",
@@ -2287,9 +2277,6 @@ if (is_win || (is_linux && !is_chromeos)) {
} else {
sources -= [
"../app/chrome_command_ids.h",
-
- #"../app/chrome_dll.rc",
- #"../app/chrome_dll_resource.h",
"../app/chrome_version.rc.version",
]
}

Powered by Google App Engine
This is Rietveld 408576698