Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: content/browser/BUILD.gn

Issue 1957683002: Address more TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@todo
Patch Set: iOS Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/policy/BUILD.gn ('k') | content/test/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/ui.gni") 6 import("//build/config/ui.gni")
7 import("//content/browser/browser.gni") 7 import("//content/browser/browser.gni")
8 import("//media/media_options.gni") 8 import("//media/media_options.gni")
9 9
10 source_set("browser") { 10 source_set("browser") {
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 ] 116 ]
117 117
118 public_deps = [ 118 public_deps = [
119 "//third_party/leveldatabase", 119 "//third_party/leveldatabase",
120 ] 120 ]
121 121
122 sources = rebase_path(content_browser_gypi_values.private_browser_sources, 122 sources = rebase_path(content_browser_gypi_values.private_browser_sources,
123 ".", 123 ".",
124 "//content") 124 "//content")
125 125
126 # TODO(GYP) these generated files are listed as sources in content_browser. 126 # TODO(GYP_GONE) these generated files are listed as sources in
127 # This is a bit suspicious. The GN grit template will make a source set 127 # content_browser. This is a bit suspicious. The GN grit template will make
128 # containing the generated code so it should be sufficient to just depend 128 # a source set containing the generated code so it should be sufficient to
129 # on the grit rule. But maybe some of these will need to be added? 129 # just depend on the grit rule. But maybe some of these will need to be
130 # added?
130 # 131 #
131 # Need this annoying rebase_path call to match what happened with the 132 # Need this annoying rebase_path call to match what happened with the
132 # sources. 133 # sources.
133 sources -= rebase_path( 134 sources -= rebase_path(
134 [ 135 [
135 "$root_gen_dir/blink/grit/devtools_resources.h", 136 "$root_gen_dir/blink/grit/devtools_resources.h",
136 "$root_gen_dir/blink/grit/devtools_resources_map.cc", 137 "$root_gen_dir/blink/grit/devtools_resources_map.cc",
137 "$root_gen_dir/blink/grit/devtools_resources_map.h", 138 "$root_gen_dir/blink/grit/devtools_resources_map.h",
138 "$root_gen_dir/content/browser/tracing/grit/tracing_resources.h", 139 "$root_gen_dir/content/browser/tracing/grit/tracing_resources.h",
139 "$root_gen_dir/ui/resources/grit/webui_resources_map.cc", 140 "$root_gen_dir/ui/resources/grit/webui_resources_map.cc",
(...skipping 13 matching lines...) Expand all
153 } 154 }
154 155
155 if (!is_win && !is_mac && !is_android && (!is_linux || !use_udev)) { 156 if (!is_win && !is_mac && !is_android && (!is_linux || !use_udev)) {
156 sources += [ "gamepad/gamepad_platform_data_fetcher.cc" ] 157 sources += [ "gamepad/gamepad_platform_data_fetcher.cc" ]
157 } 158 }
158 159
159 if (enable_basic_printing || enable_print_preview) { 160 if (enable_basic_printing || enable_print_preview) {
160 deps += [ "//printing" ] 161 deps += [ "//printing" ]
161 } 162 }
162 163
163 # TODO(GYP)
164 # [chrome_multiple_dll!=1', {
165 # 'dependencies': [
166 # '../third_party/WebKit/public/blink.gyp:blink',
167 # ],
168 # }],
169 if (!is_mac) { 164 if (!is_mac) {
170 deps += [ "//sandbox" ] 165 deps += [ "//sandbox" ]
171 } 166 }
172 if (!is_android) { 167 if (!is_android) {
173 deps += [ "//content/browser/tracing:resources" ] 168 deps += [ "//content/browser/tracing:resources" ]
174 } 169 }
175 if ((use_udev && is_posix) || is_mac || is_win) { 170 if ((use_udev && is_posix) || is_mac || is_win) {
176 deps += [ "//tools/battor_agent:battor_agent_lib" ] 171 deps += [ "//tools/battor_agent:battor_agent_lib" ]
177 sources += [ 172 sources += [
178 "tracing/power_tracing_agent.cc", 173 "tracing/power_tracing_agent.cc",
(...skipping 358 matching lines...) Expand 10 before | Expand all | Expand 10 after
537 if (!is_component_build) { 532 if (!is_component_build) {
538 public_deps = [ 533 public_deps = [
539 ":browser", 534 ":browser",
540 ] 535 ]
541 } else { 536 } else {
542 public_deps = [ 537 public_deps = [
543 "//third_party/leveldatabase", 538 "//third_party/leveldatabase",
544 ] 539 ]
545 } 540 }
546 } 541 }
OLDNEW
« no previous file with comments | « components/policy/BUILD.gn ('k') | content/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698