components/metrics/BUILD.gn - Issue 1957683002: Address more TODO(GYP) in the GN build.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/metrics/BUILD.gn

Issue 1957683002: Address more TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@todo

Patch Set: iOS Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 declare_args() {	5 declare_args() {

6 # Overrides os name in uma metrics log to "Blimp".	6 # Overrides os name in uma metrics log to "Blimp".

7 metrics_use_blimp = false	7 metrics_use_blimp = false

8 }	8 }

9	9

10 # GYP version: components/metrics.gypi:metrics	10 # GYP version: components/metrics.gypi:metrics

(...skipping 351 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
362	362

363 # These are only used by the blimp team, which has entirely migrated to gn,	363 # These are only used by the blimp team, which has entirely migrated to gn,

364 # so this logic is not replicated in the gyp file.	364 # so this logic is not replicated in the gyp file.

365 if (metrics_use_blimp) {	365 if (metrics_use_blimp) {

366 defines = [	366 defines = [

367 "OVERRIDE_OS_NAME_TO_BLIMP",	367 "OVERRIDE_OS_NAME_TO_BLIMP",

368 "ENABLE_REPORTING_BLIMP",	368 "ENABLE_REPORTING_BLIMP",

369 ]	369 ]

370 }	370 }

371 }	371 }

372 # TODO(GYP): metrics_chromeos

OLD	NEW

« no previous file with comments | « components/crash/content/app/BUILD.gn ('k') | components/mus/ws/BUILD.gn » ('j') | no next file with comments »