Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: components/BUILD.gn

Issue 1957683002: Address more TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@todo
Patch Set: iOS Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/tools/BUILD.gn ('k') | components/crash.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/ui.gni") 6 import("//build/config/ui.gni")
7 import("//testing/test.gni") 7 import("//testing/test.gni")
8 import("//tools/grit/repack.gni") 8 import("//tools/grit/repack.gni")
9 9
10 if (is_android) { 10 if (is_android) {
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 if (target_cpu != "arm") { 157 if (target_cpu != "arm") {
158 # TODO(GYP): iOS arm builds of libwebp don't work yet. 158 # TODO(GYP): iOS arm builds of libwebp don't work yet.
159 deps += [ "//components/webp_transcode:unit_tests" ] 159 deps += [ "//components/webp_transcode:unit_tests" ]
160 } 160 }
161 } else { # !iOS 161 } else { # !iOS
162 deps += [ 162 deps += [
163 "//components/autofill/content/browser:unit_tests", 163 "//components/autofill/content/browser:unit_tests",
164 "//components/autofill/content/renderer:unit_tests", 164 "//components/autofill/content/renderer:unit_tests",
165 "//components/cast_certificate:unit_tests", 165 "//components/cast_certificate:unit_tests",
166 "//components/certificate_transparency:unit_tests", 166 "//components/certificate_transparency:unit_tests",
167 "//components/crash/content/app:unit_tests",
167 "//components/data_reduction_proxy/content/browser:unit_tests", 168 "//components/data_reduction_proxy/content/browser:unit_tests",
168 "//components/data_use_measurement/content:unit_tests", 169 "//components/data_use_measurement/content:unit_tests",
169 "//components/devtools_http_handler:unit_tests", 170 "//components/devtools_http_handler:unit_tests",
170 "//components/display_compositor:unit_tests", 171 "//components/display_compositor:unit_tests",
171 "//components/dom_distiller/content/browser:unit_tests", 172 "//components/dom_distiller/content/browser:unit_tests",
172 "//components/domain_reliability:unit_tests", 173 "//components/domain_reliability:unit_tests",
173 "//components/error_page/renderer:unit_tests", 174 "//components/error_page/renderer:unit_tests",
174 "//components/favicon/content:unit_tests", 175 "//components/favicon/content:unit_tests",
175 "//components/gcm_driver/instance_id:unit_tests", 176 "//components/gcm_driver/instance_id:unit_tests",
176 "//components/guest_view/browser:unit_tests", 177 "//components/guest_view/browser:unit_tests",
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
263 deps += [ "//components/rlz:unit_tests" ] 264 deps += [ "//components/rlz:unit_tests" ]
264 } 265 }
265 if (is_chromeos) { 266 if (is_chromeos) {
266 deps += [ 267 deps += [
267 "//components/arc:unit_tests", 268 "//components/arc:unit_tests",
268 "//components/ownership:unit_tests", 269 "//components/ownership:unit_tests",
269 "//components/user_manager:unit_tests", 270 "//components/user_manager:unit_tests",
270 ] 271 ]
271 } 272 }
272 273
273 # TODO(GYP) need this target.
274 #'breakpad/app/crash_keys_win_unittest.cc',
275
276 if (enable_configuration_policy) { 274 if (enable_configuration_policy) {
277 deps += [ 275 deps += [
278 "//components/policy/core/browser:unit_tests", 276 "//components/policy/core/browser:unit_tests",
279 "//components/policy/core/common:unit_tests", 277 "//components/policy/core/common:unit_tests",
280 ] 278 ]
281 } 279 }
282 280
283 if (toolkit_views) { 281 if (toolkit_views) {
284 # TODO bug 522654 Enable this when the undefined symbol is fixed in 282 # TODO bug 522654 Enable this when the undefined symbol is fixed in
285 # web_modal such that this links. 283 # web_modal such that this links.
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
358 "${target_gen_dir}/components_browsertests_manifest/AndroidManifest.xml" 356 "${target_gen_dir}/components_browsertests_manifest/AndroidManifest.xml"
359 } 357 }
360 358
361 android_resources("components_browsertests_resources") { 359 android_resources("components_browsertests_resources") {
362 testonly = true 360 testonly = true
363 resource_dirs = [ "//components/test/android/browsertests_apk/res" ] 361 resource_dirs = [ "//components/test/android/browsertests_apk/res" ]
364 custom_package = "org.chromium.components_browsertests_apk" 362 custom_package = "org.chromium.components_browsertests_apk"
365 } 363 }
366 364
367 # GYP: //components/components_tests.gyp:components_junit_tests 365 # GYP: //components/components_tests.gyp:components_junit_tests
368 # TODO(GYP): Delete this target once recipes no longer require it. 366 # TODO(GYP_GONE): Delete this target once recipes no longer require it.
369 junit_binary("components_junit_tests") { 367 junit_binary("components_junit_tests") {
370 java_files = [ "//testing/android/junit/DummyTest.java" ] 368 java_files = [ "//testing/android/junit/DummyTest.java" ]
371 } 369 }
372 } 370 }
373 371
374 if (!is_ios) { 372 if (!is_ios) {
375 test("components_browsertests") { 373 test("components_browsertests") {
376 defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ] 374 defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ]
377 375
378 sources = [ 376 sources = [
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
480 "//base/test:test_support_perf", 478 "//base/test:test_support_perf",
481 "//components/scheduler", 479 "//components/scheduler",
482 "//components/visitedlink/browser", 480 "//components/visitedlink/browser",
483 "//content/test:test_support", 481 "//content/test:test_support",
484 "//testing/gtest", 482 "//testing/gtest",
485 "//testing/perf", 483 "//testing/perf",
486 "//url", 484 "//url",
487 ] 485 ]
488 } 486 }
489 } 487 }
OLDNEW
« no previous file with comments | « chrome/tools/BUILD.gn ('k') | components/crash.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698