Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(597)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/tools/BUILD.gn
Issue
1957683002
:
Address more TODO(GYP) in the GN build. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@todo
Patch Set: iOS
Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/common/extensions/api/BUILD.gn
chrome/install_static/BUILD.gn
chrome/installer/BUILD.gn
chrome/installer/linux/BUILD.gn
chrome/installer/mini_installer/BUILD.gn
chrome/installer/test/BUILD.gn
chrome/installer/util/BUILD.gn
chrome/test/BUILD.gn
chrome/tools/BUILD.gn
components/BUILD.gn
components/crash.gypi
components/crash/content/app/BUILD.gn
components/metrics/BUILD.gn
components/mus/ws/BUILD.gn
components/policy/BUILD.gn
content/browser/BUILD.gn
content/test/BUILD.gn
crypto/BUILD.gn
third_party/WebKit/Source/core/BUILD.gn
third_party/WebKit/Source/modules/BUILD.gn
View unified diff
|
Download patch
« no previous file with comments
|
« chrome/test/BUILD.gn
('k') |
components/BUILD.gn »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
# Copyright 2014 The Chromium Authors. All rights reserved.
2
# Use of this source code is governed by a BSD-style license that can be
3
# found in the LICENSE file.
4
5
# This target just provides references to the Chrome tools to bring them into
6
# the build.
7
group("tools") {
8
testonly = true
9
if (is_linux && !is_chromeos) {
10
# TODO(GYP): Figure out which of these work and are needed on other platform s.
11
deps = [
12
"//chrome/tools/service_discovery_sniffer",
13
]
14
} else if (is_mac) {
15
deps = [
16
"//chrome/tools/mac_helpers",
17
]
18
}
19
}
OLD
NEW
« no previous file with comments
|
« chrome/test/BUILD.gn
('k') |
components/BUILD.gn »
('j') |
no next file with comments »
Issue 1957683002: Address more TODO(GYP) in the GN build. (Closed)
Created 4 years, 7 months ago by brettw
Modified 4 years, 7 months ago
Reviewers: brucedawson, Lei Zhang
Base URL: https://chromium.googlesource.com/chromium/src.git@todo
Comments: 5
This is Rietveld
408576698
Chromium Code Reviews
Issue 1957683002:
Address more TODO(GYP) in the GN build. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@todo