Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Side by Side Diff: chrome/installer/util/BUILD.gn

Issue 1957683002: Address more TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@todo
Patch Set: iOS Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/installer/test/BUILD.gn ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/chrome_build.gni") 5 import("//build/config/chrome_build.gni")
6 import("//testing/test.gni") 6 import("//testing/test.gni")
7 7
8 # This file deliberately has no default "util" target so dependants have to 8 # This file deliberately has no default "util" target so dependants have to
9 # specify with the ":with_no_strings" or ":with_rc_strings" variants. Random 9 # specify with the ":with_no_strings" or ":with_rc_strings" variants. Random
10 # code that ends up getting linked into chrome proper should depend on the 10 # code that ends up getting linked into chrome proper should depend on the
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 "//chrome/common:constants", 45 "//chrome/common:constants",
46 "//components/variations", 46 "//components/variations",
47 "//content/public/common:result_codes", 47 "//content/public/common:result_codes",
48 ] 48 ]
49 49
50 # The constants target checks the Chrome distribution from this target. Both 50 # The constants target checks the Chrome distribution from this target. Both
51 # targets have to be linked together in practice. 51 # targets have to be linked together in practice.
52 allow_circular_includes_from = [ "//chrome/common:constants" ] 52 allow_circular_includes_from = [ "//chrome/common:constants" ]
53 53
54 if (is_win) { 54 if (is_win) {
55 # TODO(GYP) installer_util on Windows.
56 # This is a bit tricky. It seems that what's currently called
57 # installer_util_nacl_win64 should be a different target with a different
58 # name ("installer_util_minimal"?) since it's not strictly the 64-bit build
59 # of that target.
60 sources = [ 55 sources = [
61 "chrome_binaries_operations.cc", 56 "chrome_binaries_operations.cc",
62 "chrome_binaries_operations.h", 57 "chrome_binaries_operations.h",
63 "chrome_browser_operations.cc", 58 "chrome_browser_operations.cc",
64 "chrome_browser_operations.h", 59 "chrome_browser_operations.h",
65 "chrome_browser_sxs_operations.cc", 60 "chrome_browser_sxs_operations.cc",
66 "chrome_browser_sxs_operations.h", 61 "chrome_browser_sxs_operations.h",
67 "chrome_frame_operations.cc", 62 "chrome_frame_operations.cc",
68 "chrome_frame_operations.h", 63 "chrome_frame_operations.h",
69 "compat_checks.cc", 64 "compat_checks.cc",
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 "wtsapi32.lib", 122 "wtsapi32.lib",
128 ] 123 ]
129 124
130 configs += [ 125 configs += [
131 "//build/config:precompiled_headers", 126 "//build/config:precompiled_headers",
132 127
133 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. 128 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
134 "//build/config/compiler:no_size_t_to_int_warning", 129 "//build/config/compiler:no_size_t_to_int_warning",
135 ] 130 ]
136 131
137 # TODO(GYP) hook up corresponding version of installer_util_nacl_win64 in GN
138 sources += [ 132 sources += [
139 "advanced_firewall_manager_win.cc", 133 "advanced_firewall_manager_win.cc",
140 "advanced_firewall_manager_win.h", 134 "advanced_firewall_manager_win.h",
141 "app_command.cc", 135 "app_command.cc",
142 "app_command.h", 136 "app_command.h",
143 "app_commands.cc", 137 "app_commands.cc",
144 "app_commands.h", 138 "app_commands.h",
145 "app_registration_data.h", 139 "app_registration_data.h",
146 "auto_launch_util.cc", 140 "auto_launch_util.cc",
147 "auto_launch_util.h", 141 "auto_launch_util.h",
(...skipping 200 matching lines...) Expand 10 before | Expand all | Expand 10 after
348 "//chrome/installer/test:alternate_version_generator_lib", 342 "//chrome/installer/test:alternate_version_generator_lib",
349 "//components/variations", 343 "//components/variations",
350 "//testing/gmock", 344 "//testing/gmock",
351 "//testing/gtest", 345 "//testing/gtest",
352 ] 346 ]
353 347
354 data = [ 348 data = [
355 "//chrome/test/data/extensions/", 349 "//chrome/test/data/extensions/",
356 "//chrome/test/data/installer/", 350 "//chrome/test/data/installer/",
357 ] 351 ]
358
359 # TODO(GYP) manifest: $(ProjectDir)\\installer\\mini_installer\\mini_install er.exe.manifest
360 } 352 }
361 } # is_win 353 } # is_win
OLDNEW
« no previous file with comments | « chrome/installer/test/BUILD.gn ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698