Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: chrome/installer/mini_installer/BUILD.gn

Issue 1957683002: Address more TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@todo
Patch Set: iOS Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/installer/linux/BUILD.gn ('k') | chrome/installer/test/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/ui.gni") 6 import("//build/config/ui.gni")
7 import("//build_overrides/v8.gni") 7 import("//build_overrides/v8.gni")
8 import("//chrome/version.gni") 8 import("//chrome/version.gni")
9 import("//third_party/icu/config.gni") 9 import("//third_party/icu/config.gni")
10 import("//ui/base/ui_features.gni") 10 import("//ui/base/ui_features.gni")
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 deps += [ "//v8" ] 151 deps += [ "//v8" ]
152 } 152 }
153 153
154 depfile = "$target_gen_dir/archive.d" 154 depfile = "$target_gen_dir/archive.d"
155 args += [ 155 args += [
156 "--depfile", 156 "--depfile",
157 rebase_path(depfile, root_build_dir), 157 rebase_path(depfile, root_build_dir),
158 ] 158 ]
159 } 159 }
160 160
161 # TODO(GYP) bug 521052: This target needs to be checked to make sure its the
162 # same size as the GYP build.
163 executable("mini_installer") { 161 executable("mini_installer") {
164 sources = [ 162 sources = [
165 "mini_installer.cc", 163 "mini_installer.cc",
166 packed_files_rc_file, 164 packed_files_rc_file,
167 ] 165 ]
168 166
169 # This target is special so we manually override most linker flags and 167 # This target is special so we manually override most linker flags and
170 # specify our own to keep the size down. 168 # specify our own to keep the size down.
171 configs -= [ 169 configs -= [
172 "//build/config:executable_config", 170 "//build/config:executable_config",
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 args = [ 210 args = [
213 "--out", 211 "--out",
214 "$target_name.exe", 212 "$target_name.exe",
215 ] 213 ]
216 deps = [ 214 deps = [
217 ":mini_installer", 215 ":mini_installer",
218 "//chrome/installer/test:alternate_version_generator", 216 "//chrome/installer/test:alternate_version_generator",
219 ] 217 ]
220 } 218 }
221 } 219 }
OLDNEW
« no previous file with comments | « chrome/installer/linux/BUILD.gn ('k') | chrome/installer/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698