Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Side by Side Diff: chrome/common/extensions/api/BUILD.gn

Issue 1957683002: Address more TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@todo
Patch Set: iOS Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/install_static/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/json_schema_api.gni") 5 import("//build/json_schema_api.gni")
6 import("schemas.gni") 6 import("schemas.gni")
7 7
8 assert(enable_extensions) 8 assert(enable_extensions)
9 9
10 # GYP version: chrome/common/extensions/api/api.gyp:chrome_api 10 # GYP version: chrome/common/extensions/api/api.gyp:chrome_api
(...skipping 22 matching lines...) Expand all
33 # include generated headers from these targets. 33 # include generated headers from these targets.
34 # TODO(brettw) this should be made unnecessary if possible. 34 # TODO(brettw) this should be made unnecessary if possible.
35 ":api", 35 ":api",
36 "//components/copresence/proto", 36 "//components/copresence/proto",
37 "//components/metrics/proto", 37 "//components/metrics/proto",
38 "//skia", 38 "//skia",
39 "//sync", 39 "//sync",
40 "//ui/accessibility:ax_gen", 40 "//ui/accessibility:ax_gen",
41 ] 41 ]
42 if (is_chromeos) { 42 if (is_chromeos) {
43 # deps += [ "<(DEPTH)/chrome/chrome.gyp:drive_proto" ] TODO(GYP) 43 deps += [ "//components/drive:proto" ]
44 } 44 }
45 deps += schema_dependencies 45 deps += schema_dependencies
46 46
47 # This must be a static library because the generated schemas have 47 # This must be a static library because the generated schemas have
48 # dependencies into both the browser and child processes, and this won't link 48 # dependencies into both the browser and child processes, and this won't link
49 # in the multi DLL build. In the child DLL, only some files are needed, and 49 # in the multi DLL build. In the child DLL, only some files are needed, and
50 # these have no dependencies into the browser, so a static library solves the 50 # these have no dependencies into the browser, so a static library solves the
51 # problem. 51 # problem.
52 generate_static_library = true 52 generate_static_library = true
53 } 53 }
OLDNEW
« no previous file with comments | « no previous file | chrome/install_static/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698