chrome/installer/BUILD.gn - Issue 1957683002: Address more TODO(GYP) in the GN build.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/installer/BUILD.gn

Issue 1957683002: Address more TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@todo

Patch Set: fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import("//build/config/chrome_build.gni")	5 import("//build/config/chrome_build.gni")

6	6

7 # Meta-target that forwards to the installer of the correct type (if any).	7 # Meta-target that forwards to the installer of the correct type (if any).

8 group("installer") {	8 group("installer") {

9 # TODO(GYP): Get the 32-bit build to work.	9 # We only make Linux installers for 64-bit desktop.

10 if (is_desktop_linux && is_chrome_branded && target_cpu == "x64") {	10 if (is_desktop_linux && is_chrome_branded && target_cpu == "x64") {

11 deps = [	11 deps = [

12 "//chrome/installer/linux",	12 "//chrome/installer/linux",

13 ]	13 ]

14 }	14 }

15 }	15 }

OLD	NEW