Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: content/browser/BUILD.gn

Issue 1957683002: Address more TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@todo
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/ui.gni") 6 import("//build/config/ui.gni")
7 import("//content/browser/browser.gni") 7 import("//content/browser/browser.gni")
8 import("//media/media_options.gni") 8 import("//media/media_options.gni")
9 9
10 source_set("browser") { 10 source_set("browser") {
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 "//ui/shell_dialogs", 118 "//ui/shell_dialogs",
119 "//ui/snapshot", 119 "//ui/snapshot",
120 "//ui/surface", 120 "//ui/surface",
121 "//ui/touch_selection", 121 "//ui/touch_selection",
122 ] 122 ]
123 123
124 sources = rebase_path(content_browser_gypi_values.private_browser_sources, 124 sources = rebase_path(content_browser_gypi_values.private_browser_sources,
125 ".", 125 ".",
126 "//content") 126 "//content")
127 127
128 # TODO(GYP) these generated files are listed as sources in content_browser. 128 # TODO(GYP_GONE) these generated files are listed as sources in
129 # This is a bit suspicious. The GN grit template will make a source set 129 # content_browser. This is a bit suspicious. The GN grit template will make
130 # containing the generated code so it should be sufficient to just depend 130 # a source set containing the generated code so it should be sufficient to
131 # on the grit rule. But maybe some of these will need to be added? 131 # just depend on the grit rule. But maybe some of these will need to be
132 # added?
132 # 133 #
133 # Need this annoying rebase_path call to match what happened with the 134 # Need this annoying rebase_path call to match what happened with the
134 # sources. 135 # sources.
135 sources -= rebase_path( 136 sources -= rebase_path(
136 [ 137 [
137 "$root_gen_dir/blink/grit/devtools_resources.h", 138 "$root_gen_dir/blink/grit/devtools_resources.h",
138 "$root_gen_dir/blink/grit/devtools_resources_map.cc", 139 "$root_gen_dir/blink/grit/devtools_resources_map.cc",
139 "$root_gen_dir/blink/grit/devtools_resources_map.h", 140 "$root_gen_dir/blink/grit/devtools_resources_map.h",
140 "$root_gen_dir/content/browser/tracing/grit/tracing_resources.h", 141 "$root_gen_dir/content/browser/tracing/grit/tracing_resources.h",
141 "$root_gen_dir/ui/resources/grit/webui_resources_map.cc", 142 "$root_gen_dir/ui/resources/grit/webui_resources_map.cc",
(...skipping 13 matching lines...) Expand all
155 } 156 }
156 157
157 if (!is_win && !is_mac && !is_android && (!is_linux || !use_udev)) { 158 if (!is_win && !is_mac && !is_android && (!is_linux || !use_udev)) {
158 sources += [ "gamepad/gamepad_platform_data_fetcher.cc" ] 159 sources += [ "gamepad/gamepad_platform_data_fetcher.cc" ]
159 } 160 }
160 161
161 if (enable_basic_printing || enable_print_preview) { 162 if (enable_basic_printing || enable_print_preview) {
162 deps += [ "//printing" ] 163 deps += [ "//printing" ]
163 } 164 }
164 165
165 # TODO(GYP)
166 # [chrome_multiple_dll!=1', {
167 # 'dependencies': [
168 # '../third_party/WebKit/public/blink.gyp:blink',
169 # ],
170 # }],
171 if (!is_mac) { 166 if (!is_mac) {
172 deps += [ "//sandbox" ] 167 deps += [ "//sandbox" ]
173 } 168 }
174 if (!is_android) { 169 if (!is_android) {
175 deps += [ "//content/browser/tracing:resources" ] 170 deps += [ "//content/browser/tracing:resources" ]
176 } 171 }
177 if ((use_udev && is_posix) || is_mac || is_win) { 172 if ((use_udev && is_posix) || is_mac || is_win) {
178 deps += [ "//tools/battor_agent:battor_agent_lib" ] 173 deps += [ "//tools/battor_agent:battor_agent_lib" ]
179 sources += [ 174 sources += [
180 "tracing/power_tracing_agent.cc", 175 "tracing/power_tracing_agent.cc",
(...skipping 354 matching lines...) Expand 10 before | Expand all | Expand 10 after
535 530
536 # See comment at the top of //content/BUILD.gn for how this works. 531 # See comment at the top of //content/BUILD.gn for how this works.
537 group("for_content_tests") { 532 group("for_content_tests") {
538 visibility = [ "//content/test/*" ] 533 visibility = [ "//content/test/*" ]
539 if (!is_component_build) { 534 if (!is_component_build) {
540 public_deps = [ 535 public_deps = [
541 ":browser", 536 ":browser",
542 ] 537 ]
543 } 538 }
544 } 539 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698