Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1647)

Side by Side Diff: components/BUILD.gn

Issue 1957683002: Address more TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@todo
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/ui.gni") 6 import("//build/config/ui.gni")
7 import("//testing/test.gni") 7 import("//testing/test.gni")
8 import("//tools/grit/repack.gni") 8 import("//tools/grit/repack.gni")
9 9
10 if (is_android) { 10 if (is_android) {
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 "//components/bookmarks/browser:unit_tests", 63 "//components/bookmarks/browser:unit_tests",
64 "//components/bookmarks/managed:unit_tests", 64 "//components/bookmarks/managed:unit_tests",
65 "//components/browser_sync/browser:unit_tests", 65 "//components/browser_sync/browser:unit_tests",
66 "//components/bubble:unit_tests", 66 "//components/bubble:unit_tests",
67 "//components/captive_portal:unit_tests", 67 "//components/captive_portal:unit_tests",
68 "//components/client_update_protocol:unit_tests", 68 "//components/client_update_protocol:unit_tests",
69 "//components/cloud_devices/common:unit_tests", 69 "//components/cloud_devices/common:unit_tests",
70 "//components/component_updater:unit_tests", 70 "//components/component_updater:unit_tests",
71 "//components/content_settings/core/browser:unit_tests", 71 "//components/content_settings/core/browser:unit_tests",
72 "//components/content_settings/core/common:unit_tests", 72 "//components/content_settings/core/common:unit_tests",
73 "//components/crash/content/app:unit_tests",
73 "//components/crx_file:unit_tests", 74 "//components/crx_file:unit_tests",
74 "//components/data_reduction_proxy/core/browser:unit_tests", 75 "//components/data_reduction_proxy/core/browser:unit_tests",
75 "//components/data_reduction_proxy/core/common:unit_tests", 76 "//components/data_reduction_proxy/core/common:unit_tests",
76 "//components/data_usage/core:unit_tests", 77 "//components/data_usage/core:unit_tests",
77 "//components/device_event_log:unit_tests", 78 "//components/device_event_log:unit_tests",
78 "//components/dom_distiller/core:unit_tests", 79 "//components/dom_distiller/core:unit_tests",
79 "//components/favicon/core:unit_tests", 80 "//components/favicon/core:unit_tests",
80 "//components/favicon_base:unit_tests", 81 "//components/favicon_base:unit_tests",
81 "//components/flags_ui:unit_tests", 82 "//components/flags_ui:unit_tests",
82 "//components/gcm_driver:unit_tests", 83 "//components/gcm_driver:unit_tests",
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 deps += [ "//components/rlz:unit_tests" ] 256 deps += [ "//components/rlz:unit_tests" ]
256 } 257 }
257 if (is_chromeos) { 258 if (is_chromeos) {
258 deps += [ 259 deps += [
259 "//components/arc:unit_tests", 260 "//components/arc:unit_tests",
260 "//components/ownership:unit_tests", 261 "//components/ownership:unit_tests",
261 "//components/user_manager:unit_tests", 262 "//components/user_manager:unit_tests",
262 ] 263 ]
263 } 264 }
264 265
265 # TODO(GYP) need this target.
266 #'breakpad/app/crash_keys_win_unittest.cc',
267
268 if (enable_configuration_policy) { 266 if (enable_configuration_policy) {
269 deps += [ 267 deps += [
270 "//components/policy/core/browser:unit_tests", 268 "//components/policy/core/browser:unit_tests",
271 "//components/policy/core/common:unit_tests", 269 "//components/policy/core/common:unit_tests",
272 ] 270 ]
273 } 271 }
274 272
275 if (toolkit_views) { 273 if (toolkit_views) {
276 # TODO bug 522654 Enable this when the undefined symbol is fixed in 274 # TODO bug 522654 Enable this when the undefined symbol is fixed in
277 # web_modal such that this links. 275 # web_modal such that this links.
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
350 "${target_gen_dir}/components_browsertests_manifest/AndroidManifest.xml" 348 "${target_gen_dir}/components_browsertests_manifest/AndroidManifest.xml"
351 } 349 }
352 350
353 android_resources("components_browsertests_resources") { 351 android_resources("components_browsertests_resources") {
354 testonly = true 352 testonly = true
355 resource_dirs = [ "//components/test/android/browsertests_apk/res" ] 353 resource_dirs = [ "//components/test/android/browsertests_apk/res" ]
356 custom_package = "org.chromium.components_browsertests_apk" 354 custom_package = "org.chromium.components_browsertests_apk"
357 } 355 }
358 356
359 # GYP: //components/components_tests.gyp:components_junit_tests 357 # GYP: //components/components_tests.gyp:components_junit_tests
360 # TODO(GYP): Delete this target once recipes no longer require it. 358 # TODO(GYP_GONE): Delete this target once recipes no longer require it.
361 junit_binary("components_junit_tests") { 359 junit_binary("components_junit_tests") {
362 java_files = [ "//testing/android/junit/DummyTest.java" ] 360 java_files = [ "//testing/android/junit/DummyTest.java" ]
363 } 361 }
364 } 362 }
365 363
366 if (!is_ios) { 364 if (!is_ios) {
367 test("components_browsertests") { 365 test("components_browsertests") {
368 defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ] 366 defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ]
369 367
370 sources = [ 368 sources = [
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
471 "//base/test:test_support_perf", 469 "//base/test:test_support_perf",
472 "//components/scheduler", 470 "//components/scheduler",
473 "//components/visitedlink/browser", 471 "//components/visitedlink/browser",
474 "//content/test:test_support", 472 "//content/test:test_support",
475 "//testing/gtest", 473 "//testing/gtest",
476 "//testing/perf", 474 "//testing/perf",
477 "//url", 475 "//url",
478 ] 476 ]
479 } 477 }
480 } 478 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698