Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Side by Side Diff: chrome/installer/mini_installer/BUILD.gn

Issue 1957683002: Address more TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@todo
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/ui.gni") 6 import("//build/config/ui.gni")
7 import("//build_overrides/v8.gni") 7 import("//build_overrides/v8.gni")
8 import("//chrome/version.gni") 8 import("//chrome/version.gni")
9 import("//third_party/icu/config.gni") 9 import("//third_party/icu/config.gni")
10 import("//ui/base/ui_features.gni") 10 import("//ui/base/ui_features.gni")
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 deps += [ "//v8" ] 159 deps += [ "//v8" ]
160 } 160 }
161 161
162 depfile = "$target_gen_dir/archive.d" 162 depfile = "$target_gen_dir/archive.d"
163 args += [ 163 args += [
164 "--depfile", 164 "--depfile",
165 rebase_path(depfile, root_build_dir), 165 rebase_path(depfile, root_build_dir),
166 ] 166 ]
167 } 167 }
168 168
169 # TODO(GYP) bug 521052: This target needs to be checked to make sure its the
170 # same size as the GYP build.
171 executable("mini_installer") { 169 executable("mini_installer") {
172 sources = [ 170 sources = [
173 "mini_installer.cc", 171 "mini_installer.cc",
174 packed_files_rc_file, 172 packed_files_rc_file,
175 ] 173 ]
176 174
177 # This target is special so we manually override most linker flags and 175 # This target is special so we manually override most linker flags and
178 # specify our own to keep the size down. 176 # specify our own to keep the size down.
179 configs -= [ 177 configs -= [
180 "//build/config:executable_config", 178 "//build/config:executable_config",
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 args = [ 219 args = [
222 "--out", 220 "--out",
223 "$target_name.exe", 221 "$target_name.exe",
224 ] 222 ]
225 deps = [ 223 deps = [
226 ":mini_installer", 224 ":mini_installer",
227 "//chrome/installer/test:alternate_version_generator", 225 "//chrome/installer/test:alternate_version_generator",
228 ] 226 ]
229 } 227 }
230 } 228 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698