Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1957653002: [Findit] Pull changelogs in batch. (Closed)

Created:
4 years, 7 months ago by Sharu Jiang
Modified:
4 years, 7 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org, mmandlis, aarya
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Pull changelogs in batch. Use 'name-status' flag to get the json changelogs in a regression range, instead of download every changelogs in a regression range and parse the changelogs. For example: https://chromium.googlesource.com/chromium/src/+log/52.0.2725.0..52.0.2726.0?... Committed: https://chromium.googlesource.com/infra/infra/+/9182172995eeae65cc98d48ceea4d42e372fc1bd

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -37 lines) Patch
M appengine/findit/common/git_repository.py View 1 4 chunks +25 lines, -14 lines 0 comments Download
M appengine/findit/common/test/git_repository_test.py View 1 1 chunk +23 lines, -23 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Sharu Jiang
[Findit] Pull changelogs in batch. Use 'name-status' flag to get the json changelogs in a ...
4 years, 7 months ago (2016-05-06 06:33:54 UTC) #2
Sharu Jiang
PTAL :)
4 years, 7 months ago (2016-05-06 06:34:32 UTC) #4
stgao
https://codereview.chromium.org/1957653002/diff/20001/appengine/findit/common/git_repository.py File appengine/findit/common/git_repository.py (right): https://codereview.chromium.org/1957653002/diff/20001/appengine/findit/common/git_repository.py#newcode261 appengine/findit/common/git_repository.py:261: 'name-status': '1'}) Will this include the file change? https://codereview.chromium.org/1957653002/diff/20001/appengine/findit/common/test/git_repository_test.py ...
4 years, 7 months ago (2016-05-06 06:59:18 UTC) #6
Sharu Jiang
https://codereview.chromium.org/1957653002/diff/20001/appengine/findit/common/git_repository.py File appengine/findit/common/git_repository.py (right): https://codereview.chromium.org/1957653002/diff/20001/appengine/findit/common/git_repository.py#newcode261 appengine/findit/common/git_repository.py:261: 'name-status': '1'}) On 2016/05/06 06:59:18, stgao wrote: > Will ...
4 years, 7 months ago (2016-05-06 17:46:13 UTC) #8
stgao
lgtm
4 years, 7 months ago (2016-05-06 17:54:23 UTC) #9
Martin Barbella
lgtm
4 years, 7 months ago (2016-05-06 18:16:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957653002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957653002/60001
4 years, 7 months ago (2016-05-06 19:33:15 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 19:40:12 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/infra/infra/+/9182172995eeae65cc98d48ceea4d...

Powered by Google App Engine
This is Rietveld 408576698