tool/input_sdk/private/js_helper.dart - Issue 1957633002: Upgrade StringBuffer, identical

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tool/input_sdk/private/js_helper.dart

Issue 1957633002: Upgrade StringBuffer, identical (Closed) Base URL: https://github.com/dart-lang/dev_compiler@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tool/input_sdk/private/js_helper.dart

diff --git a/tool/input_sdk/private/js_helper.dart b/tool/input_sdk/private/js_helper.dart

index 522729371a179ad77104f6622ef26adbeff5b059..00bc4b5d1be31d0aa022a1a8cd94eb33d3c26c71 100644

--- a/tool/input_sdk/private/js_helper.dart

+++ b/tool/input_sdk/private/js_helper.dart

@@ -484,12 +484,6 @@ class Primitives {

JS('void', '#[#] = #', object, key, value);

}

- static bool identicalImplementation(a, b) {

- return JS('bool', '# == null', a)

- ? JS('bool', '# == null', b)

- : JS('bool', '# === #', a, b);

- }

static StackTrace extractStackTrace(Error error) {

return getTraceFromException(JS('', r'#.$thrownJsError', error));

}

« no previous file with comments | « tool/input_sdk/patch/core_patch.dart ('k') | tool/sdk_expected_errors.txt » ('j') | no next file with comments »