Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: lib/runtime/dart_sdk.js

Issue 1957633002: Upgrade StringBuffer, identical (Closed) Base URL: https://github.com/dart-lang/dev_compiler@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | tool/input_sdk/lib/core/string_buffer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart_sdk.js
diff --git a/lib/runtime/dart_sdk.js b/lib/runtime/dart_sdk.js
index 6e024e35a4371fbaa454f96cf147303873a30ea3..f7e60d0c91b0a2fbeafa5ba1a858d8e0c8d5e2eb 100644
--- a/lib/runtime/dart_sdk.js
+++ b/lib/runtime/dart_sdk.js
@@ -9290,9 +9290,6 @@ dart_library.library('dart_sdk', null, /* Imports */[
}
object[key] = value;
}
- static identicalImplementation(a, b) {
- return a == null ? b == null : a === b;
- }
static extractStackTrace(error) {
return _js_helper.getTraceFromException(error.$thrownJsError);
}
@@ -9333,10 +9330,9 @@ dart_library.library('dart_sdk', null, /* Imports */[
valueFromDateString: [dart.dynamic, [dart.dynamic]],
getProperty: [dart.dynamic, [dart.dynamic, dart.dynamic]],
setProperty: [dart.void, [dart.dynamic, dart.dynamic, dart.dynamic]],
- identicalImplementation: [core.bool, [dart.dynamic, dart.dynamic]],
extractStackTrace: [core.StackTrace, [core.Error]]
}),
- names: ['initializeStatics', 'objectHashCode', '_parseIntError', 'parseInt', '_parseDoubleError', 'parseDouble', 'objectTypeName', 'objectToString', 'dateNow', 'initTicker', 'currentUri', '_fromCharCodeApply', 'stringFromCodePoints', 'stringFromCharCodes', 'stringFromNativeUint8List', 'stringFromCharCode', 'stringConcatUnchecked', 'flattenString', 'getTimeZoneName', 'getTimeZoneOffsetInMinutes', 'valueFromDecomposedDate', 'patchUpY2K', 'lazyAsJsDate', 'getYear', 'getMonth', 'getDay', 'getHours', 'getMinutes', 'getSeconds', 'getMilliseconds', 'getWeekday', 'valueFromDateString', 'getProperty', 'setProperty', 'identicalImplementation', 'extractStackTrace']
+ names: ['initializeStatics', 'objectHashCode', '_parseIntError', 'parseInt', '_parseDoubleError', 'parseDouble', 'objectTypeName', 'objectToString', 'dateNow', 'initTicker', 'currentUri', '_fromCharCodeApply', 'stringFromCodePoints', 'stringFromCharCodes', 'stringFromNativeUint8List', 'stringFromCharCode', 'stringConcatUnchecked', 'flattenString', 'getTimeZoneName', 'getTimeZoneOffsetInMinutes', 'valueFromDecomposedDate', 'patchUpY2K', 'lazyAsJsDate', 'getYear', 'getMonth', 'getDay', 'getHours', 'getMinutes', 'getSeconds', 'getMilliseconds', 'getWeekday', 'valueFromDateString', 'getProperty', 'setProperty', 'extractStackTrace']
});
_js_helper.Primitives.mirrorFunctionCacheName = '$cachedFunction';
_js_helper.Primitives.mirrorInvokeCacheName = '$cachedInvocation';
@@ -28021,7 +28017,7 @@ dart_library.library('dart_sdk', null, /* Imports */[
names: ['apply', '_toMangledNames']
});
core.identical = function(a, b) {
- return _js_helper.Primitives.identicalImplementation(a, b);
+ return a == null ? b == null : a === b;
};
dart.fn(core.identical, core.bool, [core.Object, core.Object]);
core.identityHashCode = function(object) {
@@ -28483,24 +28479,11 @@ dart_library.library('dart_sdk', null, /* Imports */[
}
writeAll(objects, separator) {
if (separator === void 0) separator = "";
- let iterator = objects[dartx.iterator];
- if (!dart.notNull(iterator.moveNext())) return;
- if (dart.notNull(separator[dartx.isEmpty])) {
- do {
- this.write(iterator.current);
- } while (dart.notNull(iterator.moveNext()));
- } else {
- this.write(iterator.current);
- while (dart.notNull(iterator.moveNext())) {
- this.write(separator);
- this.write(iterator.current);
- }
- }
+ this[_contents] = core.StringBuffer._writeAll(this[_contents], objects, separator);
}
writeln(obj) {
if (obj === void 0) obj = "";
- this.write(obj);
- this.write("\n");
+ this[_writeString](`${obj}\n`);
}
clear() {
this[_contents] = "";
@@ -28511,6 +28494,25 @@ dart_library.library('dart_sdk', null, /* Imports */[
[_writeString](str) {
this[_contents] = _js_helper.Primitives.stringConcatUnchecked(this[_contents], dart.as(str, core.String));
}
+ static _writeAll(string, objects, separator) {
+ let iterator = objects[dartx.iterator];
+ if (!dart.notNull(iterator.moveNext())) return string;
+ if (dart.notNull(separator[dartx.isEmpty])) {
+ do {
+ string = core.StringBuffer._writeOne(string, iterator.current);
+ } while (dart.notNull(iterator.moveNext()));
+ } else {
+ string = core.StringBuffer._writeOne(string, iterator.current);
+ while (dart.notNull(iterator.moveNext())) {
+ string = core.StringBuffer._writeOne(string, separator);
+ string = core.StringBuffer._writeOne(string, iterator.current);
+ }
+ }
+ return string;
+ }
+ static _writeOne(string, obj) {
+ return _js_helper.Primitives.stringConcatUnchecked(string, `${obj}`);
+ }
};
core.StringBuffer[dart.implements] = () => [core.StringSink];
dart.setSignature(core.StringBuffer, {
@@ -28522,7 +28524,12 @@ dart_library.library('dart_sdk', null, /* Imports */[
writeln: [dart.void, [], [core.Object]],
clear: [dart.void, []],
[_writeString]: [dart.void, [dart.dynamic]]
- })
+ }),
+ statics: () => ({
+ _writeAll: [core.String, [core.String, core.Iterable, core.String]],
+ _writeOne: [core.String, [core.String, core.Object]]
+ }),
+ names: ['_writeAll', '_writeOne']
});
core.Symbol = class Symbol extends core.Object {
static new(name) {
« no previous file with comments | « no previous file | tool/input_sdk/lib/core/string_buffer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698