Issue 195763025: fix a leak

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 195763025: fix a leak (Closed)

Created:
6 years, 9 months ago by hal.canary

Modified:
6 years, 9 months ago

Reviewers:
bungeman-skia, sugoi1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

fix a leak Committed: http://code.google.com/p/skia/source/detail?r=13814

Patch Set 2 : AnotherPatchSet #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	tests/SerializationTest.cpp	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hal.canary

ptal http://108.170.217.252:10117/builders/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release-Valgrind/builds/354/steps/RunTests/logs/stdio

6 years, 9 months ago (2014-03-14 18:16:04 UTC) #1

bungeman-skia

lgtm with one nit https://codereview.chromium.org/195763025/diff/1/tests/SerializationTest.cpp File tests/SerializationTest.cpp (right): https://codereview.chromium.org/195763025/diff/1/tests/SerializationTest.cpp#newcode13 tests/SerializationTest.cpp:13: #include "SkValidatingReadBuffer.h" Should #include "SkTemplates.h" ...

6 years, 9 months ago (2014-03-14 18:49:05 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/195763025/20001

6 years, 9 months ago (2014-03-14 19:21:47 UTC) #4

Message was sent while issue was closed.

Change committed as 13814

Expand Messages | Collapse Messages

Issue 195763025: fix a leak (Closed)

Description

Patch Set 1 #

Patch Set 2 : AnotherPatchSet #

Messages