Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Unified Diff: gm/rebaseline_server/static/loader.js

Issue 195763013: make rebaseline_server client check schema version number (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/rebaseline_server/static/loader.js
diff --git a/gm/rebaseline_server/static/loader.js b/gm/rebaseline_server/static/loader.js
index 645724c194a5d649b3214d5c12fe3ac0fcc157cb..d2c7288a2fdb3601707ccb441cb35df33470e96f 100644
--- a/gm/rebaseline_server/static/loader.js
+++ b/gm/rebaseline_server/static/loader.js
@@ -89,6 +89,12 @@ Loader.controller(
$timeout(
function(){location.reload();},
timeToReload - timeNow);
+ } else if (dataHeader[constants.KEY__HEADER__SCHEMA_VERSION] !=
+ constants.REBASELINE_SERVER_SCHEMA_VERSION_NUMBER) {
+ $scope.loadingMessage = "ERROR: Got JSON file with schema version "
+ + dataHeader[constants.KEY__HEADER__SCHEMA_VERSION]
+ + " but expected schema version "
+ + constants.REBASELINE_SERVER_SCHEMA_VERSION_NUMBER;
} else {
$scope.loadingMessage = "Processing data, please wait...";
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698