Issue 195763008: Revert 255158 "Avoid hitting the thread check when WebRtcAudioRe..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 195763008: Revert 255158 "Avoid hitting the thread check when WebRtcAudioRe..." (Closed)

Created:
6 years, 9 months ago by vrk (LEFT CHROMIUM)

Modified:
6 years, 9 months ago

Reviewers:
no longer working on chromium

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 255158 "Avoid hitting the thread check when WebRtcAudioRe..." This needs to be reverted because it's causing complete audio loss in apps using WebRTC. BUG=351895, 264611 > Avoid hitting the thread check when WebRtcAudioRenderer is going away. > > We need to reset the render_thread_checker and render_converter_ when the WebRtcAudioRenderer is going away. > > NOTRY=true > > BUG=264611 > TEST=manual test webrtc with --enable-audio-track-processor > > Review URL: https://codereview.chromium.org/178153007 TBR=xians@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256664

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -28 lines)			Patch
M	trunk/src/content/renderer/media/media_stream_audio_processor.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/content/renderer/media/media_stream_audio_processor.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	trunk/src/content/renderer/media/webrtc_audio_device_impl.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	trunk/src/content/renderer/media/webrtc_audio_device_impl.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	trunk/src/content/renderer/media/webrtc_audio_renderer.cc	View	2 chunks	+5 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r256664.

Expand Messages | Collapse Messages