Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 19576002: Make atob() / btoa() argument non optional (Closed)

Created:
7 years, 5 months ago by do-not-use
Modified:
7 years, 5 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, lgombos
Visibility:
Public.

Description

Make atob() / btoa() argument non optional According to the latest specification, the argument to atob() / btoa() should not be optional: http://www.whatwg.org/specs/web-apps/current-work/multipage/webappapis.html#windowbase64 This patch makes Blink behave according to the specification. The argument is also mandatory in Firefox and IE10. atob() / btoa() are also moved to their own WindowBase64 interface which the Window interface implements. This does not change the behavior but this is closer to the specification and it will make exposing those methods to workers easier later on. BUG=261126 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154419

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -18 lines) Patch
M LayoutTests/fast/dom/Window/atob-btoa.html View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/Window/atob-btoa-expected.txt View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/Window.idl View 2 chunks +1 line, -5 lines 0 comments Download
A + Source/core/page/WindowBase64.idl View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
do-not-use
7 years, 5 months ago (2013-07-17 12:41:29 UTC) #1
haraken
Given the spec, Firefox and IE10, LGTM.
7 years, 5 months ago (2013-07-17 13:11:55 UTC) #2
arv (Not doing code reviews)
LGTM It would be nice to split this out of the .cpp/.h files too. https://code.google.com/p/chromium/issues/detail?id=261226
7 years, 5 months ago (2013-07-17 16:59:18 UTC) #3
do-not-use
On 2013/07/17 16:59:18, arv wrote: > LGTM > > It would be nice to split ...
7 years, 5 months ago (2013-07-17 17:02:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/19576002/1
7 years, 5 months ago (2013-07-17 17:07:40 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-17 19:12:13 UTC) #6
Message was sent while issue was closed.
Change committed as 154419

Powered by Google App Engine
This is Rietveld 408576698