cc: Add GpuMemoryBufferId to TextureMailbox

cc: Add GpuMemoryBufferId to TextureMailbox

This will allow to identify the corresponding IOSurface in the browser.

BUG=604052
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/606662dfdeb98d3d7d6dc3b9e5dd61e7660dcd7f
Cr-Commit-Position: refs/heads/master@{#393424}

[ccameron, 2016-05-06 00:50:23]

Description was changed from

==========
cc: Add GpuMemoryBufferId to TextureMailbox

This will allow to identify the corresponding IOSurface in the browser.

BUG=604052
==========

to

==========
cc: Add GpuMemoryBufferId to TextureMailbox

This will allow to identify the corresponding IOSurface in the browser.

BUG=604052
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[ccameron, 2016-05-06 09:22:52]

ccameron@chromium.org changed reviewers:
+ reveman@chromium.org

[ccameron, 2016-05-06 09:22:52]

Is this more what you were looking for?

[ccameron, 2016-05-11 22:18:15]

reveman@, do you have time to take a look at this?

https://codereview.chromium.org/1957583002/diff/40001/third_party/WebKit/publ...
File third_party/WebKit/public/platform/WebExternalTextureMailbox.h (right):

https://codereview.chromium.org/1957583002/diff/40001/third_party/WebKit/publ...
third_party/WebKit/public/platform/WebExternalTextureMailbox.h:43: bool
nearestNeighbor = false;
This will need to be populated for the GMB-backed resources created in Blink
(canvas, webgl, etc).

[reveman, 2016-05-12 01:00:17]

yeah, this lgtm

[ccameron, 2016-05-12 01:13:11]

ccameron@chromium.org changed reviewers:
+ dcheng@chromium.org

[ccameron, 2016-05-12 01:13:12]

Adding dcheng@ for security and webkit/

[dcheng, 2016-05-12 02:57:54]

Do we / can we / should we do any validation of GpuMemoryBufferId? What happens
if the renderer makes up a value for this?

[ccameron, 2016-05-12 07:56:37]

On 2016/05/12 02:57:54, dcheng wrote:
> Do we / can we / should we do any validation of GpuMemoryBufferId? What
happens
> if the renderer makes up a value for this?

GpuMemoryBufferId is scoped to the renderer process id.

That said, I think I restricted GMB Ids too much, so they can't access content
that they'll need to. I'll follow up on an email.

[ccameron, 2016-05-12 20:14:34]

On 2016/05/12 07:56:37, ccameron wrote:
> On 2016/05/12 02:57:54, dcheng wrote:
> > Do we / can we / should we do any validation of GpuMemoryBufferId? What
> happens
> > if the renderer makes up a value for this?
> 
> GpuMemoryBufferId is scoped to the renderer process id.
> 
> That said, I think I restricted GMB Ids too much, so they can't access content
> that they'll need to. I'll follow up on an email.

Okay, I've verified that this is not too restricting, and that GMB IDs are
indeed scoped to the renderer process (so multiple renderers have the GMB "1").

Does this lg then?

[dcheng, 2016-05-12 22:16:30]

ipc lgtm

Thanks for verifying my question: if a renderer wants to shoot itself in the
foot by using the wrong GMB ID, that sounds fine, since my main worry was
potential influence between renderers.

[ccameron, 2016-05-12 22:55:18]

Thanks!

[ccameron, 2016-05-12 22:55:23]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-05-12 22:55:23]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/1957583002/#ps80001
(title: "unsigned -> signed")

[commit-bot: I haz the power, 2016-05-12 22:55:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1957583002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1957583002/80001

[commit-bot: I haz the power, 2016-05-13 01:52:27]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-13 01:54:23]

Description was changed from

==========
cc: Add GpuMemoryBufferId to TextureMailbox

This will allow to identify the corresponding IOSurface in the browser.

BUG=604052
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Add GpuMemoryBufferId to TextureMailbox

This will allow to identify the corresponding IOSurface in the browser.

BUG=604052
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/606662dfdeb98d3d7d6dc3b9e5dd61e7660dcd7f
Cr-Commit-Position: refs/heads/master@{#393424}
==========

[commit-bot: I haz the power, 2016-05-13 01:54:24]

Patchset 5 (id:??) landed as
https://crrev.com/606662dfdeb98d3d7d6dc3b9e5dd61e7660dcd7f
Cr-Commit-Position: refs/heads/master@{#393424}