Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1957553003: EDK: Plumb Handle/HandleVector yet one more layer down: MessageInTransit. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work787_edk_handle_13.6
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Plumb Handle/HandleVector yet one more layer down: MessageInTransit. The "remaining" layer is TransportData and things that deal with it (e.g., serialization code). R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b7dbc87691e8f9ddb85e2ae367293dace441776d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -68 lines) Patch
M mojo/edk/system/channel_endpoint.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/local_message_pipe_endpoint.cc View 2 chunks +5 lines, -15 lines 0 comments Download
M mojo/edk/system/message_in_transit.h View 5 chunks +23 lines, -22 lines 0 comments Download
M mojo/edk/system/message_in_transit.cc View 3 chunks +31 lines, -19 lines 0 comments Download
M mojo/edk/system/message_pipe.cc View 1 chunk +9 lines, -11 lines 0 comments Download
M mojo/edk/system/transport_data.h View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/transport_data.cc View 2 chunks +22 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 4 (1 generated)
viettrungluu
(Depends on https://codereview.chromium.org/1959523002/.)
4 years, 7 months ago (2016-05-05 23:35:54 UTC) #1
azani
lgtm
4 years, 7 months ago (2016-05-06 13:50:04 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-06 16:57:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b7dbc87691e8f9ddb85e2ae367293dace441776d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698