blimp/engine/app/blimp_engine_crash_keys.cc - Issue 1957553002: Revert "Add DumpWithoutCrashing and crash keys to get more context"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/engine/app/blimp_engine_crash_keys.cc

Issue 1957553002: Revert "Add DumpWithoutCrashing and crash keys to get more context" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/engine/app/blimp_engine_crash_keys.cc

diff --git a/blimp/engine/app/blimp_engine_crash_keys.cc b/blimp/engine/app/blimp_engine_crash_keys.cc

index 39c68e3821f6ae7268f9b55e84e610c5c743ce44..bb2fcfdbc956a184c8fe1147611487ed26d0bdfa 100644

--- a/blimp/engine/app/blimp_engine_crash_keys.cc

+++ b/blimp/engine/app/blimp_engine_crash_keys.cc

@@ -65,11 +65,6 @@ size_t RegisterEngineCrashKeys() {

crash_keys::kSmallSize},

{ "initrf_root_process_is_live", crash_keys::kSmallSize},

{ "initrf_root_proxy_is_live", crash_keys::kSmallSize},

- // Temporary for https://crbug.com/600441

- { "cookie_url", crash_keys::kSmallSize },

- { "cookie_first_party", crash_keys::kSmallSize },

- { "security_policy_origin_lock", crash_keys::kSmallSize },

};

return base::debug::InitCrashKeys(engine_keys, arraysize(engine_keys),

« no previous file with comments | « no previous file | chrome/common/crash_keys.cc » ('j') | content/browser/child_process_security_policy_impl.h » ('J')