cc : Track opacity animation changes on effect tree

cc/layers/layer.cc

 // Copyright 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/layer.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 1649 matching lines @@
 
     } else {
       node->data.local_maximum_animation_target_scale = 0.f;
       node->data.local_starting_animation_scale = 0.f;
       node->data.has_only_translation_animations = true;
     }
     transform_tree.set_needs_update(true);
   }
 }
 
+void Layer::OnOpacityIsCurrentlyAnimatingChanged(bool is_currently_animating) {
+  DCHECK(layer_tree_host_);
+  EffectTree& effect_tree = layer_tree_host_->property_trees()->effect_tree;
+  EffectNode* node = effect_tree.Node(effect_tree_index());
+  if (!node)

[ajuma, 2016/05/09 16:56:55]

When does this happen? (That is, when does a layer that's getting animation
notifications have an invalid property tree index?)

[jaydasika, 2016/05/10 20:22:29]

In a lot of tests, almost all LayerTreeHostAnimationTests

[ajuma, 2016/05/10 20:46:20]

Ah, this is on Layer, so it might be that we're just starting an animation but
haven't built property trees yet.

+    return;
+
+  if (node->owner_id == id())
+    node->data.is_currently_animating_opacity = is_currently_animating;
+}
+
+void Layer::OnOpacityIsPotentiallyAnimatingChanged(
+    bool has_potential_animation) {
+  DCHECK(layer_tree_host_);
+  EffectTree& effect_tree = layer_tree_host_->property_trees()->effect_tree;
+  EffectNode* node = effect_tree.Node(effect_tree_index());
+  if (!node)
+    return;
+  if (node->owner_id == id()) {
+    node->data.has_potential_opacity_animation = has_potential_animation;

[ajuma, 2016/05/09 16:56:55]

This also needs to take Layer::OpacityCanAnimateOnImplThread into account (like
property_tree_builder does).

[jaydasika, 2016/05/10 20:22:29]

Done.

+    effect_tree.set_needs_update(true);
+  }
+}
+
 bool Layer::HasActiveAnimationForTesting() const {
   return layer_tree_host_ ? layer_tree_host_->HasActiveAnimationForTesting(this)
                           : false;
 }
 
 ScrollbarLayerInterface* Layer::ToScrollbarLayer() {
   return nullptr;
 }
 
 RenderingStatsInstrumentation* Layer::rendering_stats_instrumentation() const {
@@ skipping 72 matching lines @@
       ->data.num_copy_requests_in_subtree;
 }
 
 gfx::Transform Layer::screen_space_transform() const {
   DCHECK_NE(transform_tree_index_, -1);
   return draw_property_utils::ScreenSpaceTransform(
       this, layer_tree_host_->property_trees()->transform_tree);
 }
 
 }  // namespace cc