Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1957523004: Rename gfx::test::TestScreen to display::test::TestScreen (Closed)

Created:
4 years, 7 months ago by oshima
Modified:
4 years, 7 months ago
Reviewers:
Daniel Erat, sky, Wez
CC:
chromium-reviews, asvitkine+watch_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename gfx::test::TestScreen to display::test::TestScreen BUG=597761 R=derat@chromium.org TBR=sky@chromium.org, wez@chromium.org Committed: https://crrev.com/4690412fbcc92a63254dfb7213a76abe1b7680f6 Cr-Commit-Position: refs/heads/master@{#392146}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -130 lines) Patch
M chrome/browser/manifest/manifest_icon_selector_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/chrome_browser_main_extra_parts_metrics_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/display/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/display/display.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A ui/display/test/test_screen.h View 1 1 chunk +53 lines, -0 lines 0 comments Download
A + ui/display/test/test_screen.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/gfx/test/test_screen.h View 1 chunk +0 lines, -48 lines 0 comments Download
D ui/gfx/test/test_screen.cc View 1 chunk +0 lines, -61 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
oshima
4 years, 7 months ago (2016-05-06 04:14:43 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957523004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957523004/1
4 years, 7 months ago (2016-05-06 04:15:04 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-06 05:14:06 UTC) #5
Daniel Erat
lgtm w/nit https://codereview.chromium.org/1957523004/diff/1/ui/display/test/test_screen.h File ui/display/test/test_screen.h (right): https://codereview.chromium.org/1957523004/diff/1/ui/display/test/test_screen.h#newcode17 ui/display/test/test_screen.h:17: // A dummy implementation of displayScreen that ...
4 years, 7 months ago (2016-05-06 17:40:07 UTC) #6
oshima
https://codereview.chromium.org/1957523004/diff/1/ui/display/test/test_screen.h File ui/display/test/test_screen.h (right): https://codereview.chromium.org/1957523004/diff/1/ui/display/test/test_screen.h#newcode17 ui/display/test/test_screen.h:17: // A dummy implementation of displayScreen that contains a ...
4 years, 7 months ago (2016-05-06 18:21:47 UTC) #7
oshima
tbr'ing trival renaming change for following directories sky -> ui/gfx, chrome/browser wez -> content/browser/media/capture/
4 years, 7 months ago (2016-05-06 18:25:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957523004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957523004/20001
4 years, 7 months ago (2016-05-06 18:25:59 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-06 20:27:18 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957523004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957523004/20001
4 years, 7 months ago (2016-05-06 20:30:01 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-06 20:49:32 UTC) #19
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 20:52:30 UTC) #21
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4690412fbcc92a63254dfb7213a76abe1b7680f6
Cr-Commit-Position: refs/heads/master@{#392146}

Powered by Google App Engine
This is Rietveld 408576698