Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1957503002:
https://groups.google.com/forum/#!topic/skia-discuss/2F2she2nQMg (Closed)
|
Created:
4 years, 7 months ago by hal.canary Modified:
4 years, 7 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
Descriptionhttps://groups.google.com/forum/#!topic/skia-discuss/2F2she2nQMg
No public API changes.
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1957503002
Committed: https://skia.googlesource.com/skia/+/3767cd6cff119a8290fb0a6afc90ce7f81cef555
Patch Set 1 #
Messages
Total messages: 23 (13 generated)
Description was changed from ========== https://groups.google.com/forum/#!topic/skia-discuss/2F2she2nQMg ========== to ========== https://groups.google.com/forum/#!topic/skia-discuss/2F2she2nQMg GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== https://groups.google.com/forum/#!topic/skia-discuss/2F2she2nQMg GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== https://groups.google.com/forum/#!topic/skia-discuss/2F2she2nQMg GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by halcanary@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957503002/1
halcanary@google.com changed reviewers: + corey.lucier@gmail.com, mtklein@google.com
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mtklein@google.com
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957503002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
Description was changed from ========== https://groups.google.com/forum/#!topic/skia-discuss/2F2she2nQMg GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== https://groups.google.com/forum/#!topic/skia-discuss/2F2she2nQMg No public API changes. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by halcanary@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957503002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
Description was changed from ========== https://groups.google.com/forum/#!topic/skia-discuss/2F2she2nQMg No public API changes. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== https://groups.google.com/forum/#!topic/skia-discuss/2F2she2nQMg No public API changes. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by halcanary@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957503002/1
Message was sent while issue was closed.
Description was changed from ========== https://groups.google.com/forum/#!topic/skia-discuss/2F2she2nQMg No public API changes. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== https://groups.google.com/forum/#!topic/skia-discuss/2F2she2nQMg No public API changes. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/3767cd6cff119a8290fb0a6afc90ce7f81cef555 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/3767cd6cff119a8290fb0a6afc90ce7f81cef555 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
