[Findit] Make sure two consecutive suspects are included in the same sub-range.

scripts/slave/recipes/findit/chromium/compile.py

Index: scripts/slave/recipes/findit/chromium/compile.py
diff --git a/scripts/slave/recipes/findit/chromium/compile.py b/scripts/slave/recipes/findit/chromium/compile.py
index ac64257cf7936ba527d8380e8760ecc3621ace2e..f5d92922d5cb76cbaa30341151ac9d57dc11ae85 100644
--- a/scripts/slave/recipes/findit/chromium/compile.py
+++ b/scripts/slave/recipes/findit/chromium/compile.py
@@ -168,6 +168,11 @@ def RunSteps(api, target_mastername, target_buildername,
       all_revisions.index(r)
           for r in set(suspected_revisions) if r in all_revisions]
   if suspected_revision_index:
+    # If two suspected revisions are consecutive, make them in the same

[chanli, 2016/05/05 22:07:06]

nit: it's also applicable for multiple suspected revisions.

[stgao, 2016/05/05 22:16:38]

OK. Updated the comment here.

+    # sub-range by removing the newer revision.
+    suspected_revision_index = [i for i in suspected_revision_index
+                                if i - 1 not in suspected_revision_index]
+
     sub_ranges = []
     remaining_revisions = all_revisions[:]
     for index in sorted(suspected_revision_index, reverse=True):
@@ -452,7 +457,7 @@ def GenTests(api):
   )
 
   # Entire regression range: (r1, r6]
-  # Suspected_revisions: [r4]
+  # Suspected_revisions: [r4, r5]
   # Expected smaller ranges: [r3, [r4, r5, r6]], [None, [r2]]
   # Actual culprit: r3
   # Should only run compile on r3, and then r2.