Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: content/child/web_url_loader_impl.cc

Issue 1957483003: Removal of SignedCertificateTimestampStore (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed constructor of SSLStatus() Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/web_url_loader_impl.cc
diff --git a/content/child/web_url_loader_impl.cc b/content/child/web_url_loader_impl.cc
index 53ce2f5e90d1f4e1da4a0ddab5b99f14029a1031..eba2c059ecbbc0e0db9a60e0e42bc0eef616ed66 100644
--- a/content/child/web_url_loader_impl.cc
+++ b/content/child/web_url_loader_impl.cc
@@ -38,7 +38,6 @@
#include "content/public/child/fixed_received_data.h"
#include "content/public/child/request_peer.h"
#include "content/public/common/browser_side_navigation_policy.h"
-#include "content/public/common/signed_certificate_timestamp_id_and_status.h"
#include "content/public/common/ssl_status.h"
#include "net/base/data_url.h"
#include "net/base/filename_util.h"
@@ -256,32 +255,9 @@ void SetSecurityStyleAndDetails(const GURL& url,
response->setSecurityStyle(securityStyle);
- SignedCertificateTimestampIDStatusList sct_list =
- ssl_status.signed_certificate_timestamp_ids;
-
- size_t num_unknown_scts = 0;
- size_t num_invalid_scts = 0;
- size_t num_valid_scts = 0;
-
- SignedCertificateTimestampIDStatusList::iterator iter;
- for (iter = sct_list.begin(); iter < sct_list.end(); ++iter) {
- switch (iter->status) {
- case net::ct::SCT_STATUS_LOG_UNKNOWN:
- num_unknown_scts++;
- break;
- case net::ct::SCT_STATUS_INVALID:
- num_invalid_scts++;
- break;
- case net::ct::SCT_STATUS_OK:
- num_valid_scts++;
- break;
- case net::ct::SCT_STATUS_NONE:
- case net::ct::SCT_STATUS_MAX:
- // These enum values do not represent SCTs that are taken into account
- // for CT compliance calculations, so we ignore them.
- break;
- }
- }
+ int num_unknown_scts = ssl_status.num_unknown_scts;
estark 2016/05/07 07:12:51 size_t (and the following lines also)
dwaxweiler 2016/05/07 13:09:40 Acknowledged.
+ int num_invalid_scts = ssl_status.num_invalid_scts;
+ int num_valid_scts = ssl_status.num_valid_scts;
blink::WebURLResponse::WebSecurityDetails webSecurityDetails(
WebString::fromUTF8(protocol), WebString::fromUTF8(key_exchange),

Powered by Google App Engine
This is Rietveld 408576698