content/browser/frame_host/navigation_controller_impl_unittest.cc - Issue 1957483003: Removal of SignedCertificateTimestampStore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl_unittest.cc

Issue 1957483003: Removal of SignedCertificateTimestampStore (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: reacted to comments of estark and Charlie and auto-formatted Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_controller_impl_unittest.cc

diff --git a/content/browser/frame_host/navigation_controller_impl_unittest.cc b/content/browser/frame_host/navigation_controller_impl_unittest.cc

index 6257838d80c884d4fd35768cc7ab9aa606628411..4c44e4e4dca260274d7bc3520929d25efb57a9b7 100644

--- a/content/browser/frame_host/navigation_controller_impl_unittest.cc

+++ b/content/browser/frame_host/navigation_controller_impl_unittest.cc

@@ -5302,9 +5302,12 @@ TEST_F(NavigationControllerTest, RendererNavigateBogusSecurityInfo) {

observer.details().ssl_status.connection_status);

EXPECT_EQ(default_ssl_status.content_status,

observer.details().ssl_status.content_status);

- EXPECT_EQ(

- 0u,

- observer.details().ssl_status.signed_certificate_timestamp_ids.size());

+ EXPECT_EQ(default_ssl_status.num_unknown_scts,

+ observer.details().ssl_status.num_unknown_scts);

+ EXPECT_EQ(default_ssl_status.num_invalid_scts,

+ observer.details().ssl_status.num_invalid_scts);

+ EXPECT_EQ(default_ssl_status.num_valid_scts,

+ observer.details().ssl_status.num_valid_scts);

EXPECT_EQ(1, main_test_rfh()->GetProcess()->bad_msg_count());

}