content/browser/loader/resource_dispatcher_host_impl.cc - Issue 1957483003: Removal of SignedCertificateTimestampStore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.cc

Issue 1957483003: Removal of SignedCertificateTimestampStore (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: reacted to latest concerns Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/loader/resource_dispatcher_host_impl.cc

diff --git a/content/browser/loader/resource_dispatcher_host_impl.cc b/content/browser/loader/resource_dispatcher_host_impl.cc

index e594cb76d5aef0b6545234d41d7bfa1bb0eee8c1..d9597adf70950edefdbbdccdcce7291bedf08425 100644

--- a/content/browser/loader/resource_dispatcher_host_impl.cc

+++ b/content/browser/loader/resource_dispatcher_host_impl.cc

@@ -1576,7 +1576,7 @@ void ResourceDispatcherHostImpl::BeginRequest(

request_data.enable_load_timing, request_data.enable_upload_progress,

do_not_prompt_for_login, request_data.referrer_policy,

request_data.visiblity_state, resource_context, filter_->GetWeakPtr(),

- report_raw_headers, !is_sync_load,

+ report_raw_headers, report_raw_headers, !is_sync_load,

dwaxweiler 2016/05/11 06:40:36 Passing report_raw_headers for send_extra_certific

IsUsingLoFi(request_data.lofi_state, delegate_, *new_request,

resource_context,

request_data.resource_type == RESOURCE_TYPE_MAIN_FRAME),

@@ -1875,6 +1875,7 @@ ResourceRequestInfoImpl* ResourceDispatcherHostImpl::CreateRequestInfo(

context,

base::WeakPtr<ResourceMessageFilter>(), // filter

false, // report_raw_headers

+ false, // send_extra_certificate_info

true, // is_async

false, // is_using_lofi

std::string()); // original_headers

@@ -2298,6 +2299,7 @@ void ResourceDispatcherHostImpl::BeginNavigationRequest(

blink::WebPageVisibilityStateVisible, resource_context,

base::WeakPtr<ResourceMessageFilter>(), // filter

false, // request_data.report_raw_headers

+ false,

true, // is_async

IsUsingLoFi(info.common_params.lofi_state, delegate_, *new_request,

resource_context, info.is_main_frame),