Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1143)

Unified Diff: src/runtime/runtime-generator.cc

Issue 1957393004: Allow Turbofan optimization of Ignition generators (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/runtime/runtime-generator.cc
diff --git a/src/runtime/runtime-generator.cc b/src/runtime/runtime-generator.cc
index 71d7059bf8bccf790fcdf346a7f4c8bea729cbef..7fc7ba6331747068a9908cbcebe0a922b68d308c 100644
--- a/src/runtime/runtime-generator.cc
+++ b/src/runtime/runtime-generator.cc
@@ -129,7 +129,16 @@ RUNTIME_FUNCTION(Runtime_GeneratorGetResumeMode) {
}
-// Returns generator continuation as a PC offset, or the magic -1 or 0 values.
+RUNTIME_FUNCTION(Runtime_GeneratorSetContext) {
+ HandleScope scope(isolate);
+ DCHECK(args.length() == 1);
+ CONVERT_ARG_HANDLE_CHECKED(JSGeneratorObject, generator, 0);
+
+ generator->set_context(isolate->context());
+ return isolate->heap()->undefined_value();
+}
+
+
RUNTIME_FUNCTION(Runtime_GeneratorGetContinuation) {
HandleScope scope(isolate);
DCHECK(args.length() == 1);
@@ -139,6 +148,45 @@ RUNTIME_FUNCTION(Runtime_GeneratorGetContinuation) {
}
+RUNTIME_FUNCTION(Runtime_GeneratorSetContinuation) {
+ HandleScope scope(isolate);
+ DCHECK(args.length() == 2);
+ CONVERT_ARG_HANDLE_CHECKED(JSGeneratorObject, generator, 0);
+ CONVERT_ARG_HANDLE_CHECKED(Smi, continuation, 1);
Benedikt Meurer 2016/05/10 10:32:08 Use CONVERT_SMI_ARG_CHECKED here.
neis 2016/05/10 11:32:06 Done.
+
+ generator->set_continuation(continuation->value());
+ return isolate->heap()->undefined_value();
+}
+
+
+RUNTIME_FUNCTION(Runtime_GeneratorReadRegister) {
+ HandleScope scope(isolate);
+ DCHECK(args.length() == 2);
+ CONVERT_ARG_HANDLE_CHECKED(JSGeneratorObject, generator, 0);
+ CONVERT_ARG_HANDLE_CHECKED(Smi, index, 1);
Benedikt Meurer 2016/05/10 10:32:08 Use CONVERT_SMI_ARG_CHECKED here.
neis 2016/05/10 11:32:06 Done.
+
+ DCHECK(FLAG_ignition && FLAG_ignition_generators);
+ DCHECK(generator->function()->shared()->HasBytecodeArray());
+
+ return generator->operand_stack()->get(index->value());
+}
+
+
+RUNTIME_FUNCTION(Runtime_GeneratorWriteRegister) {
+ HandleScope scope(isolate);
+ DCHECK(args.length() == 3);
+ CONVERT_ARG_HANDLE_CHECKED(JSGeneratorObject, generator, 0);
+ CONVERT_ARG_HANDLE_CHECKED(Smi, index, 1);
Benedikt Meurer 2016/05/10 10:32:08 Use CONVERT_SMI_ARG_CHECKED here.
neis 2016/05/10 11:32:06 Done.
+ CONVERT_ARG_HANDLE_CHECKED(Object, value, 2);
+
+ DCHECK(FLAG_ignition && FLAG_ignition_generators);
+ DCHECK(generator->function()->shared()->HasBytecodeArray());
+
+ generator->operand_stack()->set(index->value(), *value);
+ return isolate->heap()->undefined_value();
+}
+
+
RUNTIME_FUNCTION(Runtime_GeneratorGetSourcePosition) {
HandleScope scope(isolate);
DCHECK(args.length() == 1);

Powered by Google App Engine
This is Rietveld 408576698