Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: net/cert/ct_policy_enforcer_unittest.cc

Issue 1957393003: Address some clean-up remarks in CT code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Proper tracking branch Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/ct_policy_enforcer_unittest.cc
diff --git a/net/cert/ct_policy_enforcer_unittest.cc b/net/cert/ct_policy_enforcer_unittest.cc
index 28a47511f657bfd8e1054e8378cb2149ae6cd35c..105b4fd76bbba5a28a4dca997ff73538b83c7dbc 100644
--- a/net/cert/ct_policy_enforcer_unittest.cc
+++ b/net/cert/ct_policy_enforcer_unittest.cc
@@ -207,7 +207,7 @@ TEST_F(CTPolicyEnforcerTest,
TEST_F(CTPolicyEnforcerTest, ConformsToCTEVPolicyIfSCTBeforeEnforcementDate) {
ct::SCTList scts;
- // This chain_ is valid for 10 years - over 121 months - so requires 5 SCTs.
+ // |chain_| is valid for 10 years - over 121 months - so requires 5 SCTs.
// All 5 SCTs will be from non-Google logs.
FillListWithSCTsOfOrigin(ct::SignedCertificateTimestamp::SCT_EMBEDDED, 5,
std::vector<std::string>(), false, &scts);
@@ -234,7 +234,7 @@ TEST_F(CTPolicyEnforcerTest, ConformsToCTEVPolicyWithNonEmbeddedSCTs) {
}
TEST_F(CTPolicyEnforcerTest, ConformsToCTEVPolicyWithEmbeddedSCTs) {
- // This chain_ is valid for 10 years - over 121 months - so requires 5 SCTs.
+ // |chain_| is valid for 10 years - over 121 months - so requires 5 SCTs.
ct::SCTList scts;
FillListWithSCTsOfOrigin(ct::SignedCertificateTimestamp::SCT_EMBEDDED, 5,
&scts);
@@ -301,7 +301,7 @@ TEST_F(CTPolicyEnforcerTest, ConformsToCTEVPolicyWithPooledEmbeddedSCTs) {
TEST_F(CTPolicyEnforcerTest, DoesNotConformToCTEVPolicyNotEnoughSCTs) {
scoped_refptr<ct::EVCertsWhitelist> non_including_whitelist(
new DummyEVCertsWhitelist(true, false));
- // This chain_ is valid for 10 years - over 121 months - so requires 5 SCTs.
+ // |chain_| is valid for 10 years - over 121 months - so requires 5 SCTs.
ct::SCTList scts;
FillListWithSCTsOfOrigin(ct::SignedCertificateTimestamp::SCT_EMBEDDED, 2,
&scts);
@@ -389,7 +389,7 @@ TEST_F(CTPolicyEnforcerTest,
AddDisqualifiedLogSCT(ct::SignedCertificateTimestamp::SCT_EMBEDDED, false,
&scts);
- // This chain_ is valid for 10 years - over 121 months - so requires 5 SCTs.
+ // |chain_| is valid for 10 years - over 121 months - so requires 5 SCTs.
EXPECT_EQ(ct::CertPolicyCompliance::CERT_POLICY_COMPLIES_VIA_SCTS,
policy_enforcer_->DoesConformToCertPolicy(chain_.get(), scts,
BoundNetLog()));
@@ -406,7 +406,7 @@ TEST_F(CTPolicyEnforcerTest,
AddDisqualifiedLogSCT(ct::SignedCertificateTimestamp::SCT_EMBEDDED, true,
&scts);
- // This chain_ is valid for 10 years - over 121 months - so requires 5 SCTs.
+ // |chain_| is valid for 10 years - over 121 months - so requires 5 SCTs.
EXPECT_EQ(ct::CertPolicyCompliance::CERT_POLICY_NOT_ENOUGH_SCTS,
policy_enforcer_->DoesConformToCertPolicy(chain_.get(), scts,
BoundNetLog()));
@@ -426,7 +426,7 @@ TEST_F(CTPolicyEnforcerTest,
for (size_t i = 1; i < scts.size(); ++i)
scts[i]->timestamp = scts[0]->timestamp;
- // This chain_ is valid for 10 years - over 121 months - so requires 5 SCTs.
+ // |chain_| is valid for 10 years - over 121 months - so requires 5 SCTs.
EXPECT_EQ(ct::CertPolicyCompliance::CERT_POLICY_NOT_ENOUGH_SCTS,
policy_enforcer_->DoesConformToCertPolicy(chain_.get(), scts,
BoundNetLog()));
@@ -460,7 +460,7 @@ TEST_F(CTPolicyEnforcerTest,
FillListWithSCTsOfOrigin(ct::SignedCertificateTimestamp::SCT_EMBEDDED,
desired_logs.size(), desired_logs, true, &scts);
- // This chain_ is valid for 10 years - over 121 months - so requires 5 SCTs.
+ // |chain_| is valid for 10 years - over 121 months - so requires 5 SCTs.
// However, there are only 4 SCTs are from distinct logs.
EXPECT_EQ(ct::CertPolicyCompliance::CERT_POLICY_NOT_ENOUGH_SCTS,
policy_enforcer_->DoesConformToCertPolicy(chain_.get(), scts,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698