Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1074)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1957393003: Address some clean-up remarks in CT code (Closed)

Created:
4 years, 7 months ago by Ryan Sleevi
Modified:
4 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews, certificate-transparency-chrome_googlegroups.com, cbentzel+watch_chromium.org, Eran Messeri
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Address some clean-up remarks in CT code BUG=none Committed: https://crrev.com/17bce7bc289f2d9e56d58c199f186ab1adcbb111 Cr-Commit-Position: refs/heads/master@{#392464}

Patch Set 1 #

Patch Set 2 : Proper tracking branch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M net/cert/ct_policy_enforcer_unittest.cc View 1 7 chunks +7 lines, -7 lines 0 comments Download

Depends on Patchset:

Issue 1941273002 Patch 90001

Messages

Total messages: 10 (5 generated)
Ryan Sleevi
4 years, 7 months ago (2016-05-09 22:12:23 UTC) #3
eroman
lgtm
4 years, 7 months ago (2016-05-09 22:13:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957393003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957393003/20001
4 years, 7 months ago (2016-05-09 22:24:50 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-09 23:09:20 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 23:10:19 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/17bce7bc289f2d9e56d58c199f186ab1adcbb111
Cr-Commit-Position: refs/heads/master@{#392464}

Powered by Google App Engine
This is Rietveld 408576698