Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: pkg/compiler/lib/src/native/enqueue.dart

Issue 1957343002: Register NativeBehavior from WorldImpact. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: dartfmt Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | pkg/compiler/lib/src/resolution/registry.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/native/enqueue.dart
diff --git a/pkg/compiler/lib/src/native/enqueue.dart b/pkg/compiler/lib/src/native/enqueue.dart
index c04509b33c66d309763733cb4bdd52800d0dd3c1..75a697938cae53c134213f82871090e1c68ea898 100644
--- a/pkg/compiler/lib/src/native/enqueue.dart
+++ b/pkg/compiler/lib/src/native/enqueue.dart
@@ -608,8 +608,6 @@ class NativeResolutionEnqueuer extends NativeEnqueuerBase {
NativeBehavior resolveJsCall(Send node, ForeignResolver resolver) {
NativeBehavior behavior = NativeBehavior.ofJsCall(
Siggi Cherem (dart-lang) 2016/05/10 01:06:18 nit: remove the extra var... possibly remove {} to
Johnni Winther 2016/05/10 09:26:42 Done.
node, reporter, compiler.parsingContext, compiler.coreTypes, resolver);
- // TODO(johnniwinther): Move registration to the world impact application.
- registerNativeBehavior(behavior, node);
return behavior;
}
@@ -626,8 +624,6 @@ class NativeResolutionEnqueuer extends NativeEnqueuerBase {
Send node, ForeignResolver resolver) {
NativeBehavior behavior = NativeBehavior.ofJsEmbeddedGlobalCall(
node, reporter, compiler.parsingContext, compiler.coreTypes, resolver);
- // TODO(johnniwinther): Move registration to the world impact application.
- registerNativeBehavior(behavior, node);
return behavior;
}
@@ -643,8 +639,6 @@ class NativeResolutionEnqueuer extends NativeEnqueuerBase {
NativeBehavior resolveJsBuiltinCall(Send node, ForeignResolver resolver) {
NativeBehavior behavior = NativeBehavior.ofJsBuiltinCall(
node, reporter, compiler.parsingContext, compiler.coreTypes, resolver);
- // TODO(johnniwinther): Move registration to the world impact application.
- registerNativeBehavior(behavior, node);
return behavior;
}
}
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | pkg/compiler/lib/src/resolution/registry.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698