Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 195733007: Changes to SkFontHost_linux (Closed)

Created:
6 years, 9 months ago by hal.canary
Modified:
6 years, 9 months ago
Reviewers:
bungeman-skia
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Changes to SkFontHost_linux * Use SkOSPath::SkPathJoin() rather than append so that SK_FONT_FILE_PREFIX does not have to end in a '/'. * Add another font to the default font list. Motivation: Some tests fail when there are no default fonts. BUG=skia:2282 Committed: http://code.google.com/p/skia/source/detail?r=13789

Patch Set 1 : AnotherPatchSet #

Total comments: 2

Patch Set 2 : AnotherPatchSet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M src/ports/SkFontHost_linux.cpp View 1 4 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hal.canary
PTAL
6 years, 9 months ago (2014-03-13 14:33:41 UTC) #1
bungeman-skia
https://codereview.chromium.org/195733007/diff/20001/src/ports/SkFontHost_linux.cpp File src/ports/SkFontHost_linux.cpp (right): https://codereview.chromium.org/195733007/diff/20001/src/ports/SkFontHost_linux.cpp#newcode364 src/ports/SkFontHost_linux.cpp:364: load_directory_fonts(dirname); Can we use SkOSPath::SkPathJoin here as well, and ...
6 years, 9 months ago (2014-03-13 15:11:05 UTC) #2
hal.canary
https://codereview.chromium.org/195733007/diff/20001/src/ports/SkFontHost_linux.cpp File src/ports/SkFontHost_linux.cpp (right): https://codereview.chromium.org/195733007/diff/20001/src/ports/SkFontHost_linux.cpp#newcode364 src/ports/SkFontHost_linux.cpp:364: load_directory_fonts(dirname); On 2014/03/13 15:11:05, bungeman1 wrote: > Can we ...
6 years, 9 months ago (2014-03-13 15:21:42 UTC) #3
bungeman-skia
lgtm
6 years, 9 months ago (2014-03-13 15:25:03 UTC) #4
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 9 months ago (2014-03-13 15:31:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/195733007/40001
6 years, 9 months ago (2014-03-13 15:31:29 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-13 16:24:51 UTC) #7
Message was sent while issue was closed.
Change committed as 13789

Powered by Google App Engine
This is Rietveld 408576698