Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: src/heap/spaces.cc

Issue 1957323003: [heap] Add page evacuation mode for new->new (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebase after fix Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/heap/spaces.cc
diff --git a/src/heap/spaces.cc b/src/heap/spaces.cc
index 6b6725a01eab8977cad4a511d3df146b6e7f399c..497a3c0261375d5e21f0b89baac4373b5229163c 100644
--- a/src/heap/spaces.cc
+++ b/src/heap/spaces.cc
@@ -1891,6 +1891,32 @@ bool SemiSpace::ReplaceWithEmptyPage(Page* old_page) {
return true;
}
+void SemiSpace::PrependPage(Page* page) {
+ // Remove page at the end.
+ Page* replacement_page = anchor()->prev_page();
+ replacement_page->next_page()->set_prev_page(replacement_page->prev_page());
+ replacement_page->prev_page()->set_next_page(replacement_page->next_page());
+ DCHECK_NE(current_page(), replacement_page);
+
+ SemiSpace* old_semi_space = reinterpret_cast<SemiSpace*>(page->owner());
+ if (page == old_semi_space->current_page()) {
+ old_semi_space->current_page_ = replacement_page;
+ }
+
+ // Replace it.
+ replacement_page->set_owner(page->owner());
+ replacement_page->SetFlags(page->GetFlags(), Page::kCopyAllFlags);
+ page->next_page()->set_prev_page(replacement_page);
+ page->prev_page()->set_next_page(replacement_page);
+ replacement_page->set_prev_page(page->prev_page());
+ replacement_page->set_next_page(page->next_page());
+ page->set_next_page(nullptr);
+ page->set_prev_page(nullptr);
+ page->SetFlags(current_page()->GetFlags(), Page::kCopyAllFlags);
+ page->set_owner(this);
+ page->InsertAfter(anchor());
+}
+
void SemiSpace::Swap(SemiSpace* from, SemiSpace* to) {
// We won't be swapping semispaces without data in them.
DCHECK_NE(from->anchor_.next_page(), &from->anchor_);
« src/heap/mark-compact.cc ('K') | « src/heap/spaces.h ('k') | test/cctest/cctest.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698